Bug 139345 - RenderObject::absoluteBoundingBoxRect() returns an incorrect height for inline images
Summary: RenderObject::absoluteBoundingBoxRect() returns an incorrect height for inlin...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-06 11:56 PST by Myles C. Maxfield
Modified: 2014-12-08 17:14 PST (History)
1 user (show)

See Also:


Attachments
Test (2.29 KB, patch)
2014-12-08 17:02 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-12-06 11:56:26 PST
RenderInline::generateCulledLineBoxRects() disregards the height of inline boxes (such as images). Instead, it always uses the font metrics's line height for the line.
Comment 1 Myles C. Maxfield 2014-12-06 12:04:52 PST
int logicalTop = rootBox.logicalTop() + (rootBox.lineStyle().font().fontMetrics().ascent() - containerStyle.font().fontMetrics().ascent());
int logicalHeight = containerStyle.font().fontMetrics().height();
Comment 2 Myles C. Maxfield 2014-12-08 17:02:45 PST
Created attachment 242863 [details]
Test
Comment 3 Myles C. Maxfield 2014-12-08 17:14:29 PST
Turns out this is correct behavior.