Bug 139341 - [GStreamer] Handle CLOCK_LOST and LATENCY messages
Summary: [GStreamer] Handle CLOCK_LOST and LATENCY messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sebastian Dröge (slomo)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-06 08:55 PST by Sebastian Dröge (slomo)
Modified: 2014-12-08 01:24 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2014-12-06 10:11 PST, Sebastian Dröge (slomo) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dröge (slomo) 2014-12-06 08:55:18 PST 
[GStreamer] Handle CLOCK_LOST and LATENCY messages
Comment 1 Sebastian Dröge (slomo) 2014-12-06 09:11:43 PST 
Patch coming once my testbuild has finished in a few minutes :)
Comment 2 Sebastian Dröge (slomo) 2014-12-06 10:11:15 PST 
Created attachment 242717 [details]
Patch
Comment 3 Philippe Normand 2014-12-07 06:53:03 PST 
I think Brendan had already CLOCK_LOST support in of his recent patches? The one he doesn't want to land :)
Comment 4 Sebastian Dröge (slomo) 2014-12-07 07:31:17 PST 
Possible, I didn't look at that patch yet but it's a good thing to merge independent of all the other stuff he has in his patch and simple enough :)
Comment 5 Gustavo Noronha (kov) 2014-12-07 10:11:04 PST 
Comment on attachment 242717 [details]
Patch

Why doesn't he want to land it? Are these messages things we can test?
Comment 6 Sebastian Dröge (slomo) 2014-12-07 10:32:57 PST 
You could probably test it but setting up an environment to run into actual problems with these will be a lot of work. It's the right thing to do though, it's what we recommend in the documentation and also in gst-launch for example.


He doesn't want to land his patches because the actual thing they're implementing (disabling audio/video streams) does not work reliable because of bugs somewhere.
Comment 7 Philippe Normand 2014-12-07 12:57:18 PST 
Comment on attachment 242717 [details]
Patch

Ok!
Comment 8 WebKit Commit Bot 2014-12-08 01:24:28 PST 
Comment on attachment 242717 [details]
Patch

Clearing flags on attachment: 242717

Committed r176940: <http://trac.webkit.org/changeset/176940>
Comment 9 WebKit Commit Bot 2014-12-08 01:24:32 PST 
All reviewed patches have been landed.  Closing bug.