Bug 139330 – AX: I cannot activate links on the mobile version of news.google.com

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

If I visit news.google.com on iPhone with VOT enabled, the mobile version by default appears. If I touch Top Stories, swipe once to the right, then double tap to activate the first top story link, nothing ahppens. Turn off VO and do the same, you’ll be brought to the proper location, which may mean a new tab.

[chris fleizach]

This is because news.google only listens for touch events and ignores all other kinds of clicks.
we need to simulate a touch event

[chris fleizach]

Created attachment 242691 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 242691 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242691&action=review

> Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:278
> +            PlatformTouchPoint::TouchPhaseType touchPhase;
> +            switch (type) {
> +            case PlatformEvent::TouchStart:
> +                touchPhase = PlatformTouchPoint::TouchPhaseBegan;
> +                break;
> +            case PlatformEvent::TouchMove:
> +                touchPhase = PlatformTouchPoint::TouchPhaseMoved;
> +                break;
> +            case PlatformEvent::TouchEnd:
> +                touchPhase = PlatformTouchPoint::TouchPhaseEnded;
> +                break;
> +            default:
> +                ASSERT_NOT_REACHED();
> +                break;
> +            }

Would be nice to pull this enum translation out into a small separate function.

> Source/WebCore/accessibility/AccessibilityObject.h:757
> +    virtual bool isDetachedFromParent() { return false; }

Is this relevant?

> LayoutTests/platform/ios-simulator/ios-accessibility/press-fires-touch-events.html:42
> +//    window.jsTestIsAsync = true;
> +
> +    if (window.accessibilityController) {
> +
> +        var button = accessibilityController.accessibleElementById("button");
> +        button.press();
> +    }
> +//    if (window.testRunner)
> +  //      testRunner.waitUntilDone();

You have some commented-out code here.

[chris fleizach]

(In reply to comment #3)
> Comment on attachment 242691 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242691&action=review
> 
> > Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:278
> > +            PlatformTouchPoint::TouchPhaseType touchPhase;
> > +            switch (type) {
> > +            case PlatformEvent::TouchStart:
> > +                touchPhase = PlatformTouchPoint::TouchPhaseBegan;
> > +                break;
> > +            case PlatformEvent::TouchMove:
> > +                touchPhase = PlatformTouchPoint::TouchPhaseMoved;
> > +                break;
> > +            case PlatformEvent::TouchEnd:
> > +                touchPhase = PlatformTouchPoint::TouchPhaseEnded;
> > +                break;
> > +            default:
> > +                ASSERT_NOT_REACHED();
> > +                break;
> > +            }
> 
> Would be nice to pull this enum translation out into a small separate
> function.

Will do

> 
> > Source/WebCore/accessibility/AccessibilityObject.h:757
> > +    virtual bool isDetachedFromParent() { return false; }
> 
> Is this relevant?

Left over from another patch. Thanks.
> 
> > LayoutTests/platform/ios-simulator/ios-accessibility/press-fires-touch-events.html:42
> > +//    window.jsTestIsAsync = true;
> > +
> > +    if (window.accessibilityController) {
> > +
> > +        var button = accessibilityController.accessibleElementById("button");
> > +        button.press();
> > +    }
> > +//    if (window.testRunner)
> > +  //      testRunner.waitUntilDone();
> 
> You have some commented-out code here.

Thanks for review

[chris fleizach]

http://trac.webkit.org/changeset/176904