Bug 139315 - [Win] proj files copying over too many resources.
Summary: [Win] proj files copying over too many resources.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 139733
  Show dependency treegraph
 
Reported: 2014-12-05 14:22 PST by Roger Fong
Modified: 2014-12-17 09:38 PST (History)
4 users (show)

See Also:


Attachments
patch (12.93 KB, patch)
2014-12-05 14:56 PST, Roger Fong
bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2014-12-05 14:22:41 PST
All they really need to copy over are the project's output DLL and the resource folder (if any)
Comment 1 Roger Fong 2014-12-05 14:24:03 PST
<rdar://problem/19148278>
Comment 2 Roger Fong 2014-12-05 14:56:55 PST
Created attachment 242667 [details]
patch
Comment 3 Brent Fulgham 2014-12-05 15:27:59 PST
Comment on attachment 242667 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242667&action=review

I think this looks good, but I have a couple of suggestions. Could you take a look and tell me if you disagree with them? r=me, but please make the adjustments I suggested.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.proj:88
> +    </CreateItem>

We should also include JSC.exe (32-and-64-bit versions), but only put them in $(AppleInternalBin32) and $(AppleInternalBin64), not the AAS location. This is really useful for people debugging the SDK loads stuff properly.

> Source/WTF/WTF.vcxproj/WTF.proj:82
> +    </CreateItem>

I don't think WTF has any resource files. Does it?

> Source/WebCore/WebCore.vcxproj/WebCore.proj:85
> +    </CreateItem>

I didn't think we had any WebCore.resources files. Do we?

> Source/WebKit/WebKit.vcxproj/WebKit.proj:85
> +    </CreateItem>

There's also WebKit.tlb, which should be added to the $(AppleInternalBin32) and $(AppleInternalBin64) locations so that people could use C# or other newer MS technologies with WebKit.
Comment 4 Roger Fong 2014-12-05 15:56:14 PST
(In reply to comment #3)
> Comment on attachment 242667 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242667&action=review
> 
> I think this looks good, but I have a couple of suggestions. Could you take
> a look and tell me if you disagree with them? r=me, but please make the
> adjustments I suggested.
> 
> > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.proj:88
> > +    </CreateItem>
> 
> We should also include JSC.exe (32-and-64-bit versions), but only put them
> in $(AppleInternalBin32) and $(AppleInternalBin64), not the AAS location.
> This is really useful for people debugging the SDK loads stuff properly.

Yeah, I left all the copying of stuff over to the AppleInternal alone.
The only change that should have been made was what gets copied to the AAS location.

> 
> > Source/WTF/WTF.vcxproj/WTF.proj:82
> > +    </CreateItem>
> 
> I don't think WTF has any resource files. Does it?

I guess I blanket changed that in case we ever do. But I'll remove it if there's no need.

> 
> > Source/WebCore/WebCore.vcxproj/WebCore.proj:85
> > +    </CreateItem>
> 
> I didn't think we had any WebCore.resources files. Do we?
Ditto.
> 
> > Source/WebKit/WebKit.vcxproj/WebKit.proj:85
> > +    </CreateItem>
> 
> There's also WebKit.tlb, which should be added to the $(AppleInternalBin32)
> and $(AppleInternalBin64) locations so that people could use C# or other
> newer MS technologies with WebKit.

See above. (unless they were never built into the bin32 folders in the first place?)
Comment 5 Roger Fong 2014-12-05 17:09:50 PST
Committed after fixes:
http://trac.webkit.org/changeset/176896