Bug 139315 – [Win] proj files copying over too many resources.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Roger Fong]

All they really need to copy over are the project's output DLL and the resource folder (if any)

[Roger Fong]

<rdar://problem/19148278>

[Roger Fong]

Created attachment 242667 [details]
patch

[Brent Fulgham]

Comment on attachment 242667 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242667&action=review

I think this looks good, but I have a couple of suggestions. Could you take a look and tell me if you disagree with them? r=me, but please make the adjustments I suggested.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.proj:88
> +    </CreateItem>

We should also include JSC.exe (32-and-64-bit versions), but only put them in $(AppleInternalBin32) and $(AppleInternalBin64), not the AAS location. This is really useful for people debugging the SDK loads stuff properly.

> Source/WTF/WTF.vcxproj/WTF.proj:82
> +    </CreateItem>

I don't think WTF has any resource files. Does it?

> Source/WebCore/WebCore.vcxproj/WebCore.proj:85
> +    </CreateItem>

I didn't think we had any WebCore.resources files. Do we?

> Source/WebKit/WebKit.vcxproj/WebKit.proj:85
> +    </CreateItem>

There's also WebKit.tlb, which should be added to the $(AppleInternalBin32) and $(AppleInternalBin64) locations so that people could use C# or other newer MS technologies with WebKit.

[Roger Fong]

(In reply to comment #3)
> Comment on attachment 242667 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242667&action=review
> 
> I think this looks good, but I have a couple of suggestions. Could you take
> a look and tell me if you disagree with them? r=me, but please make the
> adjustments I suggested.
> 
> > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.proj:88
> > +    </CreateItem>
> 
> We should also include JSC.exe (32-and-64-bit versions), but only put them
> in $(AppleInternalBin32) and $(AppleInternalBin64), not the AAS location.
> This is really useful for people debugging the SDK loads stuff properly.

Yeah, I left all the copying of stuff over to the AppleInternal alone.
The only change that should have been made was what gets copied to the AAS location.

> 
> > Source/WTF/WTF.vcxproj/WTF.proj:82
> > +    </CreateItem>
> 
> I don't think WTF has any resource files. Does it?

I guess I blanket changed that in case we ever do. But I'll remove it if there's no need.

> 
> > Source/WebCore/WebCore.vcxproj/WebCore.proj:85
> > +    </CreateItem>
> 
> I didn't think we had any WebCore.resources files. Do we?
Ditto.
> 
> > Source/WebKit/WebKit.vcxproj/WebKit.proj:85
> > +    </CreateItem>
> 
> There's also WebKit.tlb, which should be added to the $(AppleInternalBin32)
> and $(AppleInternalBin64) locations so that people could use C# or other
> newer MS technologies with WebKit.

See above. (unless they were never built into the bin32 folders in the first place?)

[Roger Fong]

Committed after fixes:
http://trac.webkit.org/changeset/176896