Bug 139307 – Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Hide Compositing Borders Button if backend returns an error that it is unsupported.

With augmentative agents, some protocol methods exist in the BackendCommands but may be unsupported by the backend.

For now, somethings can just respond as "unsupported" and we can update the UI appropriately. Things like CompositingBorders where we always send a request.

We may need to look into an alternative solution since we don't want an "isSupported" for every operation. This is just easy since we always make the request.

[Radar WebKit Bug Importer]

<rdar://problem/19159939>

[Joseph Pecoraro]

Created attachment 242655 [details]
[PATCH] Proposed Fix

[Darin Adler]

Comment on attachment 242655 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=242655&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:450
> +            if (error === "unsupported")
> +                button.enabled = false;

Is this really a one-shot? I would have expected this to say:

    button.enabled = error !== "unsupported";

[Joseph Pecoraro]

Comment on attachment 242655 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=242655&action=review

>> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:450
>> +                button.enabled = false;
> 
> Is this really a one-shot? I would have expected this to say:
> 
>     button.enabled = error !== "unsupported";

You're right, it isn't exactly a one-shot. It would happen each time the DOMTreeContentView is shown. I'll take your suggestion, this is not performance sensitive.

[Joseph Pecoraro]

http://trac.webkit.org/changeset/177108