Bug 139305 - Removed the custom allocator for ParserArena
Summary: Removed the custom allocator for ParserArena
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-05 10:29 PST by Geoffrey Garen
Modified: 2014-12-05 14:12 PST (History)
0 users

See Also:

Attachments
Patch (6.37 KB, patch)
2014-12-05 10:33 PST, Geoffrey Garen 		ggaren: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2014-12-05 10:29:23 PST 
Removed the custom allocator for ParserArena
Comment 1 Geoffrey Garen 2014-12-05 10:33:52 PST 
Created attachment 242642 [details]
Patch
Comment 2 Michael Saboff 2014-12-05 10:42:17 PST 
Comment on attachment 242642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242642&action=review

r=me

> Source/JavaScriptCore/ChangeLog:24
> +        pools anymore, since wej ust call malloc/free directly.

Typo "wej ust" should be "we just"
Comment 3 Geoffrey Garen 2014-12-05 14:08:44 PST 
Comment on attachment 242642 [details]
Patch

Actually, it looks like I started with an incorrect baseline.

This patch is a 1% regression on JSBench if you run with the parsing cache disabled, and a 2% regression on Octane2-CodeLoad. So, there is a slight advantage to an explicit arena in this case.
Comment 4 Geoffrey Garen 2014-12-05 14:12:06 PST 
I landed the removal of reset() in <https://trac.webkit.org/changeset/176871>.