RESOLVED FIXED Bug 139305
Removed the custom allocator for ParserArena 
https://bugs.webkit.org/show_bug.cgi?id=139305
Summary Removed the custom allocator for ParserArena
Geoffrey Garen
Reported 2014-12-05 10:29:23 PST
Removed the custom allocator for ParserArena
Attachments
Patch (6.37 KB, patch)
2014-12-05 10:33 PST, Geoffrey Garen 		ggaren: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2014-12-05 10:33:52 PST
Created attachment 242642 [details] Patch
Michael Saboff
Comment 2 2014-12-05 10:42:17 PST
Comment on attachment 242642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242642&action=review r=me > Source/JavaScriptCore/ChangeLog:24 > + pools anymore, since wej ust call malloc/free directly. Typo "wej ust" should be "we just"
Geoffrey Garen
Comment 3 2014-12-05 14:08:44 PST
Comment on attachment 242642 [details] Patch Actually, it looks like I started with an incorrect baseline. This patch is a 1% regression on JSBench if you run with the parsing cache disabled, and a 2% regression on Octane2-CodeLoad. So, there is a slight advantage to an explicit arena in this case.
Geoffrey Garen
Comment 4 2014-12-05 14:12:06 PST
I landed the removal of reset() in <https://trac.webkit.org/changeset/176871>.
Note You need to log in before you can comment on or make changes to this bug.