Bug 139291 - WKBundleCSSStyleDeclarationRef needs to be a real API::Object
Summary: WKBundleCSSStyleDeclarationRef needs to be a real API::Object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-04 22:24 PST by Sam Weinig
Modified: 2014-12-05 10:29 PST (History)
2 users (show)

See Also:


Attachments
Patch (14.55 KB, patch)
2014-12-04 22:29 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (14.55 KB, patch)
2014-12-04 22:29 PST, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-12-04 22:24:20 PST
WKBundleCSSStyleDeclarationRef needs to be a real API::Object
Comment 1 Sam Weinig 2014-12-04 22:29:17 PST
Created attachment 242618 [details]
Patch
Comment 2 Sam Weinig 2014-12-04 22:29:47 PST
Created attachment 242619 [details]
Patch
Comment 3 mitz 2014-12-04 22:56:44 PST
Comment on attachment 242619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242619&action=review

> Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h:45
> +    static PassRefPtr<InjectedBundleCSSStyleDeclarationHandle> create(WebCore::CSSStyleDeclaration&);

This isn’t implemented anywhere?
Comment 4 Sam Weinig 2014-12-04 23:21:25 PST
(In reply to comment #3)
> Comment on attachment 242619 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242619&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h:45
> > +    static PassRefPtr<InjectedBundleCSSStyleDeclarationHandle> create(WebCore::CSSStyleDeclaration&);
> 
> This isn’t implemented anywhere?

Oops. I will remove it.
Comment 5 Anders Carlsson 2014-12-05 10:29:43 PST
Committed r176849: <http://trac.webkit.org/changeset/176849>