Bug 139264 - Don't lock perf tests in run-webkit-tests
Summary: Don't lock perf tests in run-webkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-04 12:10 PST by Alexey Proskuryakov
Modified: 2014-12-04 13:49 PST (History)
4 users (show)

See Also:


Attachments
proposed patch (12.40 KB, patch)
2014-12-04 12:15 PST, Alexey Proskuryakov
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-12-04 12:10:42 PST
We have some code that "locks" tests in LayoutTests/perf, because they are timing sensitive, and would like to run on a separate thread. But this code is broken in several ways:

1. It doesn't do anything, because LayoutTests/perf is a leaf directory, and all these tests run sequentially even without locking.
2. It doesn't prevent other tests from running at the same time, so we have the timing problems that we were trying to avoid.
3. The locking code is tangled with code that starts and stops httpd, which is just incorrect, and very confusing.

As a result, perf tests are skipped on Mac entirely. I'd like to remove the code, and if someone wants to revive the tests, a new correct solution should be found. Ossy suggested running these tests as a separate step, which makes sense to me, but would complicate error reporting on buildbot and EWS.
Comment 1 Alexey Proskuryakov 2014-12-04 12:15:40 PST
Created attachment 242580 [details]
proposed patch
Comment 2 Daniel Bates 2014-12-04 13:45:00 PST
Comment on attachment 242580 [details]
proposed patch

rs=me
Comment 3 Alexey Proskuryakov 2014-12-04 13:49:23 PST
Committed <http://trac.webkit.org/r176814>.