RESOLVED FIXED 139249
Add a way to delete local storage origins modified after a given date
https://bugs.webkit.org/show_bug.cgi?id=139249
Summary Add a way to delete local storage origins modified after a given date
Anders Carlsson
Reported 2014-12-03 18:30:15 PST
Add a way to delete local storage origins modified between two given dates
Attachments
Patch (8.63 KB, patch)
2014-12-03 18:32 PST, Anders Carlsson
no flags
Patch (8.47 KB, patch)
2014-12-03 18:47 PST, Anders Carlsson
thorton: review+
Anders Carlsson
Comment 1 2014-12-03 18:32:11 PST
WebKit Commit Bot
Comment 2 2014-12-03 18:35:06 PST
Attachment 242547 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:441: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2014-12-03 18:47:25 PST
WebKit Commit Bot
Comment 4 2014-12-03 18:50:02 PST
Attachment 242548 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:441: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 5 2014-12-04 00:36:34 PST
(In reply to comment #3) > Created attachment 242548 [details] > Patch It will break the EFL build if you land it as is. Of course you are allowed to do it since it is in WebKit2. ../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp: In function 'WTF::Optional<long int> WebKit::fileCreationTime(const WTF::String&)': ../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:131:57: error: enumeral and non-enumeral type in conditional expression [-Werror] return getFileCreationTime(filePath, time) ? time : Nullopt; ^ ../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp: In function 'WTF::Optional<long int> WebKit::fileModificationTime(const WTF::String&)': ../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:137:61: error: enumeral and non-enumeral type in conditional expression [-Werror] return getFileModificationTime(filePath, time) ? time : Nullopt; ^
Csaba Osztrogonác
Comment 6 2014-12-04 00:41:42 PST
Any idea how to fix this warning properly?
Csaba Osztrogonác
Comment 7 2014-12-04 02:39:03 PST
Using Optional<time_t>(Nullopt) instead of Nullopt fixed the build issue for me, and I think it can be a proper fix.
Anders Carlsson
Comment 8 2014-12-04 08:34:59 PST
Csaba Osztrogonác
Comment 9 2014-12-04 09:43:42 PST
(In reply to comment #8) > Committed r176794: <http://trac.webkit.org/changeset/176794> Thanks for breaking the build intentionally. :-/
Csaba Osztrogonác
Comment 10 2014-12-04 09:43:56 PST
Anders Carlsson
Comment 11 2014-12-04 09:47:32 PST
(In reply to comment #9) > (In reply to comment #8) > > Committed r176794: <http://trac.webkit.org/changeset/176794> > > Thanks for breaking the build intentionally. :-/ You're welcome.
Csaba Osztrogonác
Comment 12 2014-12-04 09:58:34 PST
(In reply to comment #11) > (In reply to comment #9) > > (In reply to comment #8) > > > Committed r176794: <http://trac.webkit.org/changeset/176794> > > > > Thanks for breaking the build intentionally. :-/ > > You're welcome. I hope you are very proud of this impolite and uncooperative behaviour. :(( I can't understand why would have been a big deal to add my fix before landing ...
Note You need to log in before you can comment on or make changes to this bug.