Add a way to delete local storage origins modified between two given dates
Created attachment 242547 [details] Patch
Attachment 242547 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:441: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 242548 [details] Patch
Attachment 242548 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:441: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Created attachment 242548 [details] > Patch It will break the EFL build if you land it as is. Of course you are allowed to do it since it is in WebKit2. ../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp: In function 'WTF::Optional<long int> WebKit::fileCreationTime(const WTF::String&)': ../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:131:57: error: enumeral and non-enumeral type in conditional expression [-Werror] return getFileCreationTime(filePath, time) ? time : Nullopt; ^ ../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp: In function 'WTF::Optional<long int> WebKit::fileModificationTime(const WTF::String&)': ../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:137:61: error: enumeral and non-enumeral type in conditional expression [-Werror] return getFileModificationTime(filePath, time) ? time : Nullopt; ^
Any idea how to fix this warning properly?
Using Optional<time_t>(Nullopt) instead of Nullopt fixed the build issue for me, and I think it can be a proper fix.
Committed r176794: <http://trac.webkit.org/changeset/176794>
(In reply to comment #8) > Committed r176794: <http://trac.webkit.org/changeset/176794> Thanks for breaking the build intentionally. :-/
I landed the fix https://trac.webkit.org/changeset/176802
(In reply to comment #9) > (In reply to comment #8) > > Committed r176794: <http://trac.webkit.org/changeset/176794> > > Thanks for breaking the build intentionally. :-/ You're welcome.
(In reply to comment #11) > (In reply to comment #9) > > (In reply to comment #8) > > > Committed r176794: <http://trac.webkit.org/changeset/176794> > > > > Thanks for breaking the build intentionally. :-/ > > You're welcome. I hope you are very proud of this impolite and uncooperative behaviour. :(( I can't understand why would have been a big deal to add my fix before landing ...