Bug 139249 - Add a way to delete local storage origins modified after a given date
Summary: Add a way to delete local storage origins modified after a given date
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-03 18:30 PST by Anders Carlsson
Modified: 2014-12-04 09:58 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.63 KB, patch)
2014-12-03 18:32 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (8.47 KB, patch)
2014-12-03 18:47 PST, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-03 18:30:15 PST 
Add a way to delete local storage origins modified between two given dates
Comment 1 Anders Carlsson 2014-12-03 18:32:11 PST 
Created attachment 242547 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-03 18:35:06 PST 
Attachment 242547 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:441:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-12-03 18:47:25 PST 
Created attachment 242548 [details]
Patch
Comment 4 WebKit Commit Bot 2014-12-03 18:50:02 PST 
Attachment 242548 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:70:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:441:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Csaba Osztrogonác 2014-12-04 00:36:34 PST 
(In reply to comment #3)
> Created attachment 242548 [details]
> Patch

It will break the EFL build if you land it as is. Of 
course you are allowed to do it since it is in WebKit2. 

../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp: In function 'WTF::Optional<long int> WebKit::fileCreationTime(const WTF::String&)':
../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:131:57: error: enumeral and non-enumeral type in conditional expression [-Werror]
     return getFileCreationTime(filePath, time) ? time : Nullopt;
                                                         ^
../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp: In function 'WTF::Optional<long int> WebKit::fileModificationTime(const WTF::String&)':
../../Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:137:61: error: enumeral and non-enumeral type in conditional expression [-Werror]
     return getFileModificationTime(filePath, time) ? time : Nullopt;
                                                             ^
Comment 6 Csaba Osztrogonác 2014-12-04 00:41:42 PST 
Any idea how to fix this warning properly?
Comment 7 Csaba Osztrogonác 2014-12-04 02:39:03 PST 
Using Optional<time_t>(Nullopt) instead of Nullopt fixed 
the build issue for me, and I think it can be a proper fix.
Comment 8 Anders Carlsson 2014-12-04 08:34:59 PST 
Committed r176794: <http://trac.webkit.org/changeset/176794>
Comment 9 Csaba Osztrogonác 2014-12-04 09:43:42 PST 
(In reply to comment #8)
> Committed r176794: <http://trac.webkit.org/changeset/176794>

Thanks for breaking the build intentionally. :-/
Comment 10 Csaba Osztrogonác 2014-12-04 09:43:56 PST 
I landed the fix https://trac.webkit.org/changeset/176802
Comment 11 Anders Carlsson 2014-12-04 09:47:32 PST 
(In reply to comment #9)
> (In reply to comment #8)
> > Committed r176794: <http://trac.webkit.org/changeset/176794>
> 
> Thanks for breaking the build intentionally. :-/

You're welcome.
Comment 12 Csaba Osztrogonác 2014-12-04 09:58:34 PST 
(In reply to comment #11)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Committed r176794: <http://trac.webkit.org/changeset/176794>
> > 
> > Thanks for breaking the build intentionally. :-/
> 
> You're welcome.

I hope you are very proud of this impolite and uncooperative behaviour. :((
I can't understand why would have been a big deal to add my fix before landing ...