Bug 139241 – <input> elements get whitespace action menu instead of editable text menu

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

<input> elements get whitespace action menu instead of editable text menu

rdar://problem/19072083

[Beth Dakin]

Created attachment 242539 [details]
Patch

[WebKit Commit Bot]

Attachment 242539 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/HitTestResult.cpp:544:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 242539 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242539&action=review

> Source/WebKit2/Shared/WebHitTestResult.h:57
>          bool isTextNode;
> +        bool isOverTextInsideFormControlElement;

I would prefer to see isTextNode and isOverTextInsideFormControlElement combined into a single isText (or maybe isOverText), since that is how it is used.

[Beth Dakin]

Thanks Sam! Tim and I talked it over, and we both think that isText/isOverText is misleading since it would not return true every single time you were over text. isTextNode() and isOverTextInsideFormControlElement() are both very specific questions that we can answer properly.

[Beth Dakin]

http://trac.webkit.org/changeset/176766