<input> elements get whitespace action menu instead of editable text menu
Created attachment 242539 [details]
Attachment 242539 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/HitTestResult.cpp:544: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] 
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 242539 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=242539&action=review
> bool isTextNode;
> + bool isOverTextInsideFormControlElement;
I would prefer to see isTextNode and isOverTextInsideFormControlElement combined into a single isText (or maybe isOverText), since that is how it is used.
Thanks Sam! Tim and I talked it over, and we both think that isText/isOverText is misleading since it would not return true every single time you were over text. isTextNode() and isOverTextInsideFormControlElement() are both very specific questions that we can answer properly.