Bug 139241 - <input> elements get whitespace action menu instead of editable text menu
Summary: <input> elements get whitespace action menu instead of editable text menu
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-12-03 16:38 PST by Beth Dakin
Modified: 2014-12-03 17:09 PST (History)
6 users (show)

See Also:

Patch (15.63 KB, patch)
2014-12-03 16:45 PST, Beth Dakin
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-12-03 16:38:03 PST
<input> elements get whitespace action menu instead of editable text menu

Comment 1 Beth Dakin 2014-12-03 16:45:08 PST
Created attachment 242539 [details]
Comment 2 WebKit Commit Bot 2014-12-03 16:47:49 PST
Attachment 242539 [details] did not pass style-queue:

ERROR: Source/WebCore/rendering/HitTestResult.cpp:544:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 11 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2014-12-03 16:53:09 PST
Comment on attachment 242539 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=242539&action=review

> Source/WebKit2/Shared/WebHitTestResult.h:57
>          bool isTextNode;
> +        bool isOverTextInsideFormControlElement;

I would prefer to see isTextNode and isOverTextInsideFormControlElement combined into a single isText (or maybe isOverText), since that is how it is used.
Comment 4 Beth Dakin 2014-12-03 17:09:18 PST
Thanks Sam! Tim and I talked it over, and we both think that isText/isOverText is misleading since it would not return true every single time you were over text. isTextNode() and isOverTextInsideFormControlElement() are both very specific questions that we can answer properly.
Comment 5 Beth Dakin 2014-12-03 17:09:46 PST