REOPENED Bug 139233
Remove isSpecifiedFont boolean from FontDescription 
https://bugs.webkit.org/show_bug.cgi?id=139233
Summary Remove isSpecifiedFont boolean from FontDescription
Antti Koivisto
Reported 2014-12-03 13:44:23 PST
it is not used much
Attachments
patch (8.29 KB, patch)
2014-12-03 13:47 PST, Antti Koivisto 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (780.74 KB, application/zip)
2014-12-03 15:07 PST, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (778.46 KB, application/zip)
2014-12-03 15:47 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-12-03 13:47:59 PST
Created attachment 242521 [details] patch
Build Bot
Comment 2 2014-12-03 15:07:14 PST
Comment on attachment 242521 [details] patch Attachment 242521 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6378789420400640 New failing tests: fast/text/backslash-to-yen-sign-euc.html editing/selection/find-yensign-and-backslash.html
Build Bot
Comment 3 2014-12-03 15:07:16 PST
Created attachment 242527 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2014-12-03 15:47:04 PST
Comment on attachment 242521 [details] patch Attachment 242521 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5170800340500480 New failing tests: fast/text/backslash-to-yen-sign-euc.html editing/selection/find-yensign-and-backslash.html
Build Bot
Comment 5 2014-12-03 15:47:06 PST
Created attachment 242532 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Antti Koivisto
Comment 6 2014-12-04 03:50:43 PST
https://trac.webkit.org/r176789 (with system font fix)
Csaba Osztrogonác
Comment 7 2014-12-04 05:07:12 PST
(In reply to comment #6) > https://trac.webkit.org/r176789 (with system font fix) It broke the non Apple builds (not in WebKit2!), plese fix it. lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderText.cpp.o):RenderText.cpp:function WebCore::RenderText::computeUseBackslashAsYenSymbol() const: error: undefined reference to 'WebCore::Font::primaryFontDataIsSystemFont() const' collect2: error: ld returned 1 exit status primaryFontDataIsSystemFont() is a Mac only thing in FontMac.mm. And it seems the reviewed and the landed patch is completely different.
WebKit Commit Bot
Comment 8 2014-12-04 06:01:41 PST
Re-opened since this is blocked by bug 139255
Note You need to log in before you can comment on or make changes to this bug.