Bug 139228 - Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
Summary: Web Inspector: Missing getter, clients never see DragToAdjustController is en...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-12-03 11:15 PST by Joseph Pecoraro
Modified: 2014-12-03 17:39 PST (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.32 KB, patch)
2014-12-03 11:16 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-12-03 11:15:22 PST 
* SUMMARY
DragToAdjustController has a setter but no getter for "enabled", yet CodeMirrorDragToAdjustNumberController tries to use it. The result is always undefined and can cause unnecessary duplicated work.
Comment 1 Radar WebKit Bug Importer 2014-12-03 11:15:47 PST 
<rdar://problem/19131615>
Comment 2 Radar WebKit Bug Importer 2014-12-03 11:15:47 PST 
<rdar://problem/19131616>
Comment 3 Joseph Pecoraro 2014-12-03 11:16:12 PST 
Created attachment 242507 [details]
[PATCH] Proposed Fix
Comment 4 Michael Saboff 2014-12-03 11:21:24 PST 
Comment on attachment 242507 [details]
[PATCH] Proposed Fix

r=me
Comment 5 Joseph Pecoraro 2014-12-03 16:57:06 PST 
Could you flip the r+ flag? That'll get this landing =)
Comment 6 WebKit Commit Bot 2014-12-03 17:39:53 PST 
Comment on attachment 242507 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 242507

Committed r176770: <http://trac.webkit.org/changeset/176770>
Comment 7 WebKit Commit Bot 2014-12-03 17:39:57 PST 
All reviewed patches have been landed.  Closing bug.