Bug 139213 - Add a stubbed out version of WebStorageNamespaceProvider
Summary: Add a stubbed out version of WebStorageNamespaceProvider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-02 16:50 PST by Anders Carlsson
Modified: 2014-12-06 13:27 PST (History)
1 user (show)

See Also:

Attachments
Patch (16.56 KB, patch)
2014-12-02 16:54 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (19.11 KB, patch)
2014-12-02 17:50 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (19.07 KB, patch)
2014-12-02 18:30 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (16.55 KB, patch)
2014-12-05 16:56 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (19.03 KB, patch)
2014-12-06 09:48 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-02 16:50:52 PST 
Add a stubbed out version of WebStorageNamespaceProvider
Comment 1 Anders Carlsson 2014-12-02 16:54:27 PST 
Created attachment 242464 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-02 16:57:23 PST 
Attachment 242464 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-12-02 17:50:29 PST 
Created attachment 242471 [details]
Patch
Comment 4 Anders Carlsson 2014-12-02 18:30:33 PST 
Created attachment 242474 [details]
Patch
Comment 5 WebKit Commit Bot 2014-12-02 18:32:12 PST 
Attachment 242474 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2014-12-05 16:56:12 PST 
Created attachment 242681 [details]
Patch
Comment 7 WebKit Commit Bot 2014-12-05 16:58:38 PST 
Attachment 242681 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Anders Carlsson 2014-12-06 09:48:03 PST 
Created attachment 242715 [details]
Patch
Comment 9 WebKit Commit Bot 2014-12-06 09:50:49 PST 
Attachment 242715 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/WebStorageNamespaceProvider.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2014-12-06 13:27:07 PST 
Comment on attachment 242715 [details]
Patch

Clearing flags on attachment: 242715

Committed r176913: <http://trac.webkit.org/changeset/176913>
Comment 11 WebKit Commit Bot 2014-12-06 13:27:10 PST 
All reviewed patches have been landed.  Closing bug.