Bug 139209 – Modernize the CSSParser code

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Modernize the CSSParser code by:
- Using more references instead of pointers
- Using nullptr instead of 0

[Chris Dumez]

Created attachment 242465 [details]
Patch

[Antti Koivisto]

Comment on attachment 242465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242465&action=review

> Source/WebCore/css/CSSParser.cpp:5966
> +    for (CSSParserValue* argument = args.current(); argument; argument = args.next()) {
>          // The call to parseFillPosition below should consume all of the
>          // arguments except the first three. Thus, an index greater than two
>          // indicates an invalid production.
> -        if (args->currentIndex() > 2)
> +        if (args.currentIndex() > 2)
>              return nullptr;

The stateful iteration of CSSParserValueList is bit strange. Wonder if it could just be a vector...

[WebKit Commit Bot]

Comment on attachment 242465 [details]
Patch

Clearing flags on attachment: 242465

Committed r176719: <http://trac.webkit.org/changeset/176719>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #3)
> Comment on attachment 242465 [details]
> Patch
> 
> Clearing flags on attachment: 242465
> 
> Committed r176719: <http://trac.webkit.org/changeset/176719>

And the trivial buildfix landed in https://trac.webkit.org/changeset/176722.
(unfortunately with wrong reference to the changeset)

But it was super easy and EWS noticed it in time. :-/