Bug 139206 – Web Inspector: CSS Minification breaks some selectors with colons

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Production builds have broken styles. Selectors with colons that may be preceded by a space (e.g. :matches, :not, :focus) are broken by magnification which removes the leading space, and changes the semantics.

  ".a :matches(...)" !== ".a:matches(...)"
  ".a :not(.b)" !== ".a:not(.b)"

* NOTES
- This has been breaking some edge cases for a while, and a lot more as we start using :matches and :not more frequently.
UserInterface/Views/DebuggerDashboardView.css:106:.toolbar:not(.small-size) .dashboard.debugger > .location :not(:first-child) {
UserInterface/Views/TimelineSidebarPanel.css:221:.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item {

[Radar WebKit Bug Importer]

<rdar://problem/19121083>

[Joseph Pecoraro]

Created attachment 242458 [details]
[PATCH] Proposed Fix

Fixes ~16 colon issues adding back 16 spaces.
Remove 74 spaces preceding "!important"s.
Overall we save 58 bytes!

[Joseph Pecoraro]

Created attachment 242459 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 242460 [details]
[PATCH] Proposed Fix - Fixed typos

[WebKit Commit Bot]

Attachment 242460 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/Scripts/cssmin.py:33:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 242460 [details]
[PATCH] Proposed Fix - Fixed typos

Clearing flags on attachment: 242460

Committed r176699: <http://trac.webkit.org/changeset/176699>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.