Bug 139196 - operationPutById's can potentially generate code for an out of date structure
Summary: operationPutById's can potentially generate code for an out of date structure
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matthew Mirman
Depends on: 139424
  Show dependency treegraph
Reported: 2014-12-02 14:07 PST by Matthew Mirman
Modified: 2014-12-10 11:59 PST (History)
6 users (show)

See Also:

operationPutByIds fix (10.05 KB, patch)
2014-12-02 14:40 PST, Matthew Mirman
no flags Details | Formatted Diff | Diff
operationPutByIds fix (11.15 KB, patch)
2014-12-04 13:35 PST, Matthew Mirman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Mirman 2014-12-02 14:07:50 PST
Similar to how operationGetByIdBuildList could have done so as seen in https://bugs.webkit.org/show_bug.cgi?id=136961
The fix will be different since the slot can not be generated separately from the put.

Patch forthcoming.
Comment 1 Matthew Mirman 2014-12-02 14:40:07 PST
Created attachment 242451 [details]
operationPutByIds fix
Comment 2 Filip Pizlo 2014-12-02 14:47:34 PST
Comment on attachment 242451 [details]
operationPutByIds fix

Can you add a test that would fail without your patch?
Comment 3 Matthew Mirman 2014-12-04 13:35:46 PST
Created attachment 242584 [details]
operationPutByIds fix

Adds a test that fails without the patch.
Comment 4 WebKit Commit Bot 2014-12-08 15:10:48 PST
Comment on attachment 242584 [details]
operationPutByIds fix

Clearing flags on attachment: 242584

Committed r176979: <http://trac.webkit.org/changeset/176979>
Comment 5 WebKit Commit Bot 2014-12-08 15:10:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Dean Jackson 2014-12-08 17:02:03 PST
I think this broke some JS tests:

Comment 7 WebKit Commit Bot 2014-12-08 17:21:40 PST
Re-opened since this is blocked by bug 139424
Comment 8 Matthew Mirman 2014-12-10 11:40:42 PST
Committed a patch similar to the reviewed patch https://bug-139196-attachments.webkit.org/attachment.cgi?id=242584 but without the failing test.

Committed r176979:  http://trac.webkit.org/changeset/177083
Comment 9 Matthew Mirman 2014-12-10 11:59:13 PST
Test added from the patch https://bugs.webkit.org/attachment.cgi?id=242584&action=edit is now included in <https://bugs.webkit.org/show_bug.cgi?id=139500>