Bug 139193 – Should use standardQuickLookMenuItem for apps that don't implement customizations

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

Should use standardQuickLookMenuItem for apps that don't implement customizations

rdar://problem/18944696

[Beth Dakin]

Created attachment 242440 [details]
Patch

[WebKit Commit Bot]

Attachment 242440 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/mac/QuickLookMacSPI.h:50:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/spi/mac/QuickLookMacSPI.h:51:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Thank you! http://trac.webkit.org/changeset/176684

[Chris Dumez]

I am getting build errors after this patch (despite the recent build fixes):
Source/WebKit/mac/WebView/WebActionMenuController.mm:80:40: error: cannot find protocol declaration for 'QLPreviewMenuItemDelegate'; did you mean 'QLPreviewPanelDelegate'?
@interface WebActionMenuController () <QLPreviewMenuItemDelegate>
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~
                                       QLPreviewPanelDelegate

Source/WebKit/mac/WebView/WebActionMenuController.mm:290:28: error: 'QLPreviewMenuItem' may not respond to 'setDelegate:' [-Werror]
        [qlPreviewLinkItem setDelegate:self];
         ~~~~~~~~~~~~~~~~~ ^
Source/WebKit/mac/WebView/WebActionMenuController.mm:290:40: error: cannot initialize a parameter of type 'id<NSFileManagerDelegate>' with an lvalue of type 'WebActionMenuController *'
        [qlPreviewLinkItem setDelegate:self];
                                       ^~~~
                                              ^
3 errors generated.