Bug 139181 - [GStreamer] Media Source sending seek event fails.
Summary: [GStreamer] Media Source sending seek event fails.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-02 04:57 PST by Bartlomiej Gajda
Modified: 2014-12-02 09:07 PST (History)
2 users (show)

See Also:

Attachments
sets the app_src stream type in WebKitMediaSourceGStreamer to seekable. (1.88 KB, patch)
2014-12-02 05:00 PST, Bartlomiej Gajda 		no flags Details | Formatted Diff | Diff
sets the stream type to seekable, changed patch name (1.91 KB, patch)
2014-12-02 08:12 PST, Bartlomiej Gajda 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bartlomiej Gajda 2014-12-02 04:57:12 PST 
There were callbacks connected to app_src on 'seek', but if stream type was not seekable, they would never launch.
Comment 1 Bartlomiej Gajda 2014-12-02 05:00:13 PST 
Created attachment 242401 [details]
sets the app_src stream type in WebKitMediaSourceGStreamer to seekable.

this will fix it.
Comment 2 Philippe Normand 2014-12-02 05:23:55 PST 
Comment on attachment 242401 [details]
sets the app_src stream type in WebKitMediaSourceGStreamer to seekable.

View in context: https://bugs.webkit.org/attachment.cgi?id=242401&action=review

> Source/WebCore/ChangeLog:3
> +        [GStreamer] To receive seek signal, we need to set app_src stream type to seekable.

This bug title could be improved I think... How about [GStreamer] MediaSource seeking fails ... ? That's the symptom, right?
Comment 3 Bartlomiej Gajda 2014-12-02 08:07:22 PST 
Does

[GStreamer] Media Source sending seek event fails.

sounds better?

I'm not sure will everything work since this, but without it MediaPlayerPrivateGStreamer::doSeek() will fail.
Comment 4 Bartlomiej Gajda 2014-12-02 08:12:53 PST 
Created attachment 242408 [details]
sets the stream type to seekable, changed patch name

Changed name accordingly.
Comment 5 WebKit Commit Bot 2014-12-02 09:07:07 PST 
Comment on attachment 242408 [details]
sets the stream type to seekable, changed patch name

Clearing flags on attachment: 242408

Committed r176664: <http://trac.webkit.org/changeset/176664>
Comment 6 WebKit Commit Bot 2014-12-02 09:07:11 PST 
All reviewed patches have been landed.  Closing bug.