Bug 139167 - Make InternalFunction inherit from JSCallee so that it has a JSScope
Summary: Make InternalFunction inherit from JSCallee so that it has a JSScope
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 136724
  Show dependency tree / graph
 
Reported: 2014-12-01 17:52 PST by Michael Saboff
Modified: 2015-01-22 18:44 PST (History)
0 users

See Also:

Attachments
Patch (7.99 KB, patch)
2014-12-01 18:03 PST, Michael Saboff 		no flags Details | Formatted Diff | Diff
Fixed ChangeLog comment (7.97 KB, patch)
2014-12-01 18:07 PST, Michael Saboff 		ggaren: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-12-01 17:52:30 PST 
InternalFunction is currently the only Callee type that doesn't have a JSScope.  This is to change InternalFunction to inherit from JSCallee so that it has a scope like all other callee types.
Comment 1 Michael Saboff 2014-12-01 18:03:02 PST 
Created attachment 242373 [details]
Patch
Comment 2 Michael Saboff 2014-12-01 18:07:29 PST 
Created attachment 242374 [details]
Fixed ChangeLog comment
Comment 3 Geoffrey Garen 2014-12-02 12:34:36 PST 
Comment on attachment 242374 [details]
Fixed ChangeLog comment

I don't think it helps to make InternalFunction have a JSScope. The VM must handle callees that are not subclasses of JSCallee, since arbitrary callees are allowed in the language / DOM API -- for example, document.all(1).