WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 139161
Clients need a way to explicitly set the title of a page preview
https://bugs.webkit.org/show_bug.cgi?id=139161
Summary
Clients need a way to explicitly set the title of a page preview
Conrad Shultz
Reported
2014-12-01 16:18:37 PST
Clients need a way to explicitly set the title of a page preview. This will allow clients to change the title after the initial page load if needed.
Attachments
Patch
(7.84 KB, patch)
2014-12-01 16:21 PST
,
Conrad Shultz
bdakin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-12-01 16:19:27 PST
<
rdar://problem/19108805
>
Conrad Shultz
Comment 2
2014-12-01 16:21:08 PST
Created
attachment 242360
[details]
Patch
Conrad Shultz
Comment 3
2014-12-01 16:29:51 PST
Comment on
attachment 242360
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=242360&action=review
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:130 > + _previewTitle = [previewTitle copy];
Oh, I think this needs adoptNS. Will add before landing.
Conrad Shultz
Comment 4
2014-12-01 16:49:23 PST
Committed
r176613
: <
http://trac.webkit.org/changeset/176613
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug