Bug 139157 - Optimize constructing JSC::Identifier from AtomicString.
Summary: Optimize constructing JSC::Identifier from AtomicString.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-01 15:04 PST by Andreas Kling
Modified: 2014-12-03 03:19 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.45 KB, patch)
2014-12-01 15:05 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-12-01 15:04:55 PST 
Constructing a Identifier from an AtomicString or an AtomicStringImpl would be more efficient if we stopped branching on the StringImpl's "isAtomic" flag.
Comment 1 Andreas Kling 2014-12-01 15:05:41 PST 
Created attachment 242352 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-01 15:07:11 PST 
Attachment 242352 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/Identifier.h:51:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Saboff 2014-12-01 15:28:49 PST 
Comment on attachment 242352 [details]
Patch

r=me
Comment 4 Andreas Kling 2014-12-01 18:20:49 PST 
Comment on attachment 242352 [details]
Patch

Clearing flags on attachment: 242352

Committed r176622: <http://trac.webkit.org/changeset/176622>
Comment 5 Andreas Kling 2014-12-01 18:20:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 David Kilzer (:ddkilzer) 2014-12-03 03:19:26 PST 
(In reply to comment #5)
> All reviewed patches have been landed.  Closing bug.

Follow-up build fix for iOS:  <http://trac.webkit.org/r176715>