RESOLVED FIXED139157
Optimize constructing JSC::Identifier from AtomicString. 
https://bugs.webkit.org/show_bug.cgi?id=139157
Summary Optimize constructing JSC::Identifier from AtomicString.
Andreas Kling
Reported 2014-12-01 15:04:55 PST
Constructing a Identifier from an AtomicString or an AtomicStringImpl would be more efficient if we stopped branching on the StringImpl's "isAtomic" flag.
Attachments
Patch (5.45 KB, patch)
2014-12-01 15:05 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-12-01 15:05:41 PST
Created attachment 242352 [details] Patch
WebKit Commit Bot
Comment 2 2014-12-01 15:07:11 PST
Attachment 242352 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Identifier.h:51: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 3 2014-12-01 15:28:49 PST
Comment on attachment 242352 [details] Patch r=me
Andreas Kling
Comment 4 2014-12-01 18:20:49 PST
Comment on attachment 242352 [details] Patch Clearing flags on attachment: 242352 Committed r176622: <http://trac.webkit.org/changeset/176622>
Andreas Kling
Comment 5 2014-12-01 18:20:53 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 6 2014-12-03 03:19:26 PST
(In reply to comment #5) > All reviewed patches have been landed. Closing bug. Follow-up build fix for iOS: <http://trac.webkit.org/r176715>
Note You need to log in before you can comment on or make changes to this bug.