WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139147
Twitter avatar moves when hovering/unhovering the "follow" button.
https://bugs.webkit.org/show_bug.cgi?id=139147
Summary
Twitter avatar moves when hovering/unhovering the "follow" button.
alan baradlay
Reported
2014-12-01 12:58:42 PST
1. Sign into twitter 2. follow @xctotd 3. load
https://twitter.com/intent/user?screen_name=xctotd
4. Now hover/unhover the "Following" button. Every time you do, the Xcode icon moves up a bit.
Attachments
Patch
(5.03 KB, patch)
2014-12-01 13:23 PST
,
alan baradlay
no flags
Details
Formatted Diff
Diff
Patch
(5.09 KB, patch)
2014-12-01 13:24 PST
,
alan baradlay
no flags
Details
Formatted Diff
Diff
Patch
(5.39 KB, patch)
2014-12-01 15:16 PST
,
alan baradlay
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
alan baradlay
Comment 1
2014-12-01 13:00:08 PST
related to
http://trac.webkit.org/changeset/81643
alan baradlay
Comment 2
2014-12-01 13:00:48 PST
rdar://problem/19096508
alan baradlay
Comment 3
2014-12-01 13:23:21 PST
Created
attachment 242336
[details]
Patch
alan baradlay
Comment 4
2014-12-01 13:24:16 PST
Created
attachment 242337
[details]
Patch
Simon Fraser (smfr)
Comment 5
2014-12-01 13:28:37 PST
Comment on
attachment 242337
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=242337&action=review
> Source/WebCore/ChangeLog:13 > + subtree in block direction, the out of flow positioned boxes are not yet taken off of the line.
"in the block direction" "taken off of the line": not sure what this means.
> Source/WebCore/ChangeLog:14 > + They are getting removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine().
will get removed?
> LayoutTests/fast/inline/out-of-flow-positioned-render-replaced-box-moves.html:32 > + }, 100);
100ms, really? Can't this all be made synchronous with offsetWidth?
alan baradlay
Comment 6
2014-12-01 15:16:30 PST
Created
attachment 242354
[details]
Patch
alan baradlay
Comment 7
2014-12-01 15:17:53 PST
(In reply to
comment #5
)
> Comment on
attachment 242337
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=242337&action=review
> > > Source/WebCore/ChangeLog:13 > > + subtree in block direction, the out of flow positioned boxes are not yet taken off of the line. > > "in the block direction" > "taken off of the line": not sure what this means. > > > Source/WebCore/ChangeLog:14 > > + They are getting removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine(). > > will get removed? >
Rephrased.
> > LayoutTests/fast/inline/out-of-flow-positioned-render-replaced-box-moves.html:32 > > + }, 100); > > 100ms, really? Can't this all be made synchronous with offsetWidth?
Unfortunately not. I managed to make it to 10ms though.
WebKit Commit Bot
Comment 8
2014-12-01 17:59:12 PST
Comment on
attachment 242354
[details]
Patch Clearing flags on attachment: 242354 Committed
r176619
: <
http://trac.webkit.org/changeset/176619
>
WebKit Commit Bot
Comment 9
2014-12-01 17:59:16 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug