WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139114
[EFL] Drop support for the EFL 1.7
https://bugs.webkit.org/show_bug.cgi?id=139114
Summary
[EFL] Drop support for the EFL 1.7
Ryuan Choi
Reported
2014-11-30 16:45:39 PST
SSIA
Attachments
Patch
(27.37 KB, patch)
2014-11-30 16:50 PST
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
Patch
(27.61 KB, patch)
2014-11-30 17:12 PST
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryuan Choi
Comment 1
2014-11-30 16:50:33 PST
Created
attachment 242294
[details]
Patch
Gyuyoung Kim
Comment 2
2014-11-30 16:55:09 PST
Comment on
attachment 242294
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=242294&action=review
> Source/cmake/OptionsEfl.cmake:-165 > -find_package(Efreet ${EFL_REQUIRED_VERSION} REQUIRED ${EFL_CONFIG_MODE})
Isn't it better to keep ${EFL_REQUIRED_VERSION} macro ? When we upgrade 1.8 with new version, I don't want to change it in many lines.
Ryuan Choi
Comment 3
2014-11-30 17:12:50 PST
Created
attachment 242295
[details]
Patch
Gyuyoung Kim
Comment 4
2014-11-30 17:35:01 PST
Comment on
attachment 242295
[details]
Patch LGTM. Please land after passing efl ews.
WebKit Commit Bot
Comment 5
2014-11-30 19:48:07 PST
Comment on
attachment 242295
[details]
Patch Clearing flags on attachment: 242295 Committed
r176589
: <
http://trac.webkit.org/changeset/176589
>
WebKit Commit Bot
Comment 6
2014-11-30 19:48:11 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug