Bug 139114 - [EFL] Drop support for the EFL 1.7
Summary: [EFL] Drop support for the EFL 1.7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-30 16:45 PST by Ryuan Choi
Modified: 2014-11-30 19:48 PST (History)
2 users (show)

See Also:

Attachments
Patch (27.37 KB, patch)
2014-11-30 16:50 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (27.61 KB, patch)
2014-11-30 17:12 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-11-30 16:45:39 PST 
SSIA
Comment 1 Ryuan Choi 2014-11-30 16:50:33 PST 
Created attachment 242294 [details]
Patch
Comment 2 Gyuyoung Kim 2014-11-30 16:55:09 PST 
Comment on attachment 242294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242294&action=review

> Source/cmake/OptionsEfl.cmake:-165
> -find_package(Efreet ${EFL_REQUIRED_VERSION} REQUIRED ${EFL_CONFIG_MODE})

Isn't it better to keep ${EFL_REQUIRED_VERSION} macro ? When we upgrade 1.8 with new version, I don't want to change it in many lines.
Comment 3 Ryuan Choi 2014-11-30 17:12:50 PST 
Created attachment 242295 [details]
Patch
Comment 4 Gyuyoung Kim 2014-11-30 17:35:01 PST 
Comment on attachment 242295 [details]
Patch

LGTM. Please land after passing efl ews.
Comment 5 WebKit Commit Bot 2014-11-30 19:48:07 PST 
Comment on attachment 242295 [details]
Patch

Clearing flags on attachment: 242295

Committed r176589: <http://trac.webkit.org/changeset/176589>
Comment 6 WebKit Commit Bot 2014-11-30 19:48:11 PST 
All reviewed patches have been landed.  Closing bug.