Bug 139096 - PropertyTable keys should be AtomicStringImpl.
Summary: PropertyTable keys should be AtomicStringImpl.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-28 23:36 PST by Andreas Kling
Modified: 2014-11-29 16:06 PST (History)
1 user (show)

See Also:

Attachments
Patch (28.19 KB, patch)
2014-11-28 23:41 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-11-28 23:36:39 PST 
Since JSC::PropertyTable keys are always Identifiers, the table should use AtomicStringImpl* rather than StringImpl* for its key type.
Any instance of a non-atomic StringImpl* in a PropertyTable would be a bug.
Comment 1 Andreas Kling 2014-11-28 23:41:06 PST 
Created attachment 242273 [details]
Patch
Comment 2 Andreas Kling 2014-11-29 16:06:34 PST 
Comment on attachment 242273 [details]
Patch

Clearing flags on attachment: 242273

Committed r176583: <http://trac.webkit.org/changeset/176583>
Comment 3 Andreas Kling 2014-11-29 16:06:37 PST 
All reviewed patches have been landed.  Closing bug.