RESOLVED FIXED Bug 139088
[EFL][jhbuild] Fix libsoup build with clang 
https://bugs.webkit.org/show_bug.cgi?id=139088
Summary [EFL][jhbuild] Fix libsoup build with clang
Csaba Osztrogonác
Reported 2014-11-28 03:32:55 PST
build errors: soup-logger.c:377:27: error: format string is not a string literal [-Werror,-Wformat-nonliteral] data = g_strdup_vprintf (format, args); ^~~~~~ soup-xmlrpc.c:302:35: error: format string is not a string literal [-Werror,-Wformat-nonliteral] fault_string = g_strdup_vprintf (fault_format, args); ^~~~~~~~~~~~ These are already fixed in upstream libsoup, let's cherry-pick the fixes.
Attachments
Patch (5.89 KB, patch)
2014-11-28 06:32 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-11-28 06:31:03 PST
EFL and GTK use different libsoup version and GTK uses a git version which isn't patchable by jhbuild. I'm going to fix EFL first and then GTK in a future patch.
Csaba Osztrogonác
Comment 2 2014-11-28 06:32:22 PST
Created attachment 242266 [details] Patch
Csaba Osztrogonác
Comment 3 2014-12-05 04:19:28 PST
Gyuyoung, could you possibly review it please? It is the last fix to be able to build all EFL dependencies with clang.
Gyuyoung Kim
Comment 4 2014-12-06 21:35:18 PST
Comment on attachment 242266 [details] Patch rs=me.
WebKit Commit Bot
Comment 5 2014-12-07 01:16:38 PST
Comment on attachment 242266 [details] Patch Clearing flags on attachment: 242266 Committed r176918: <http://trac.webkit.org/changeset/176918>
WebKit Commit Bot
Comment 6 2014-12-07 01:16:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.