Bug 139088 - [EFL][jhbuild] Fix libsoup build with clang
Summary: [EFL][jhbuild] Fix libsoup build with clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency tree / graph
 
Reported: 2014-11-28 03:32 PST by Csaba Osztrogonác
Modified: 2015-05-18 02:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.89 KB, patch)
2014-11-28 06:32 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-11-28 03:32:55 PST 
build errors:

soup-logger.c:377:27: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
 data = g_strdup_vprintf (format, args);
                          ^~~~~~
soup-xmlrpc.c:302:35: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
 fault_string = g_strdup_vprintf (fault_format, args);
                                  ^~~~~~~~~~~~

These are already fixed in upstream libsoup, let's cherry-pick the fixes.
Comment 1 Csaba Osztrogonác 2014-11-28 06:31:03 PST 
EFL and GTK use different libsoup version and GTK uses a git version which
isn't patchable by jhbuild. I'm going to fix EFL first and then GTK in a
future patch.
Comment 2 Csaba Osztrogonác 2014-11-28 06:32:22 PST 
Created attachment 242266 [details]
Patch
Comment 3 Csaba Osztrogonác 2014-12-05 04:19:28 PST 
Gyuyoung, could you possibly review it please? It is the 
last fix to be able to build all EFL dependencies with clang.
Comment 4 Gyuyoung Kim 2014-12-06 21:35:18 PST 
Comment on attachment 242266 [details]
Patch

rs=me.
Comment 5 WebKit Commit Bot 2014-12-07 01:16:38 PST 
Comment on attachment 242266 [details]
Patch

Clearing flags on attachment: 242266

Committed r176918: <http://trac.webkit.org/changeset/176918>
Comment 6 WebKit Commit Bot 2014-12-07 01:16:41 PST 
All reviewed patches have been landed.  Closing bug.