Bug 139071 – AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

ATK fails to expose inline text elements which have accessible object attributes and/or event handlers. Examples:

* span with an onclick handler
* abbr with a title attribute
* time with a datetime attribute

These need to be separate accessible objects. The appropriate role is ATK_ROLE_STATIC, which was added to ATK v2.15.2.

[Radar WebKit Bug Importer]

<rdar://problem/19087164>

[Joanmarie Diggs]

Created attachment 242240 [details]
Patch

[Build Bot]

Comment on attachment 242240 [details]
Patch

Attachment 242240 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4580211198787584

New failing tests:
accessibility/roles-exposed.html

[Build Bot]

Created attachment 242241 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 242240 [details]
Patch

Attachment 242240 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5156600104878080

New failing tests:
accessibility/roles-exposed.html

[Build Bot]

Created attachment 242242 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Joanmarie Diggs]

Created attachment 242243 [details]
Patch

[Joanmarie Diggs]

Comment on attachment 242243 [details]
Patch

Note that the "expected" UNKNOWN roles are due to the need to bump the minimum ATK version in the GTK -- and EFL if they want to -- jhbuild. See bug 139070. In the meantime, this patch demonstrates that the inline text elements are now being exposed (albeit with a less-than-ideal role).

[Joanmarie Diggs]

Chris, when you get a chance, could you please review this? Thanks!

[chris fleizach]

Comment on attachment 242243 [details]
Patch

Can we make the time element accessible on its own so we don't need to check date time in the list of attributes to check against all elements? InlineRole is a bit of a strange name. I don't have a better idea though.

[Joanmarie Diggs]

Created attachment 242492 [details]
Patch

[Joanmarie Diggs]

Comment on attachment 242492 [details]
Patch

(In reply to comment #10)
> Can we make the time element accessible on its own so we don't need to check
> date time in the list of attributes to check against all elements?

Makes sense.

Related aside, that attribute also applies to <ins> and <del>. And if there is value in exposing datetime for <time> for ATs (which I gather from Steve Faulkner and others there is), I assume that value also applies to modification-related elements. So I made time + ins + del accessible on their own. (And also created a couple more roles-exposed.html items to test those.)

> InlineRole is a bit of a strange name. I don't have a better idea though.

I gave it more thought today, and I'm still at a loss. Hopefully it will not be needed all that often, so if and when a better idea appears it should be simple enough to change.

[chris fleizach]

Comment on attachment 242492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242492&action=review

r=me with minor update

> Source/WebCore/accessibility/AccessibilityObject.cpp:1970
> +    if (hasTagName(insTag) || hasTagName(delTag) || hasTagName(timeTag))

we can probably just write this as
return hasTagName(insTag) || hasTagName(delTag) || hasTagName(timeTag)

[Joanmarie Diggs]

Created attachment 242501 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 242501 [details]
Patch

Clearing flags on attachment: 242501

Committed r176731: <http://trac.webkit.org/changeset/176731>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.