RESOLVED FIXED 139066
Add a stubbed out WebVisitedLinkStore to WebViewGroup 
https://bugs.webkit.org/show_bug.cgi?id=139066
Summary Add a stubbed out WebVisitedLinkStore to WebViewGroup
Anders Carlsson
Reported 2014-11-26 10:53:21 PST
Add a stubbed out WebVisitedLinkStore to WebViewGroup
Attachments
Patch (12.51 KB, patch)
2014-11-26 10:53 PST, Anders Carlsson 		koivisto: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-11-26 10:53:49 PST
Created attachment 242236 [details] Patch
WebKit Commit Bot
Comment 2 2014-11-26 10:55:06 PST
Attachment 242236 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebVisitedLinkStore.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2014-11-26 11:45:57 PST
Comment on attachment 242236 [details] Patch Rejecting attachment 242236 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242236, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114. error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/6218118250627072
Anders Carlsson
Comment 4 2014-11-27 09:59:50 PST
Committed r176551: <http://trac.webkit.org/changeset/176551>
Note You need to log in before you can comment on or make changes to this bug.