Bug 139065 - Add a Page::setVisitedLinkStore member function
Summary: Add a Page::setVisitedLinkStore member function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-26 10:28 PST by Anders Carlsson
Modified: 2014-11-27 09:58 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2014-11-26 10:29 PST, Anders Carlsson 		koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-11-26 10:28:29 PST 
Add a Page::setVisitedLinkStore member function
Comment 1 Anders Carlsson 2014-11-26 10:29:00 PST 
Created attachment 242233 [details]
Patch
Comment 2 Antti Koivisto 2014-11-26 10:32:11 PST 
Comment on attachment 242233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242233&action=review

> Source/WebCore/page/Page.cpp:1648
> +void Page::setVisitedLinkStore(PassRefPtr<VisitedLinkStore> visitedLinkStore)
> +{
> +    if (m_visitedLinkStore)
> +        m_visitedLinkStore->removePage(*this);
> +
> +    m_visitedLinkStore = visitedLinkStore;
> +
> +    if (m_visitedLinkStore)
> +        m_visitedLinkStore->addPage(*this);

Do we really want to be to set a null store?
Comment 3 WebKit Commit Bot 2014-11-26 11:27:26 PST 
Comment on attachment 242233 [details]
Patch

Rejecting attachment 242233 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242233, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/5904429609910272
Comment 4 Anders Carlsson 2014-11-27 09:58:24 PST 
Committed r176550: <http://trac.webkit.org/changeset/176550>