Bug 139058 - [CSS Grid Layout] Wrong arguments passed to computeNormalizedFractionBreadth
Summary: [CSS Grid Layout] Wrong arguments passed to computeNormalizedFractionBreadth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on: 139059
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2014-11-26 03:57 PST by Sergio Villar Senin
Modified: 2015-01-20 01:19 PST (History)
12 users (show)

See Also:

Attachments
Patch (8.90 KB, patch)
2015-01-19 06:40 PST, Sergio Villar Senin 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2014-11-26 03:57:07 PST 
RenderGrid::computeNormalizedFractionBreadth() is supposed to get as fourth argument either the grid element's content box size or the max-size of a particular grid item. For the former we were incorrectly passing the free space after distributing the available space to tracks.

Apart from that, that method has a bug in its implementation. As we were using the free space instead of the grid element's content box size, we didn't have to subtract the usedBreadth of grid tracks from the passed in value. That does not work for the case of the caller passing the max-size of a particular item.
Comment 1 Sergio Villar Senin 2015-01-19 06:40:03 PST 
Created attachment 244902 [details]
Patch
Comment 2 Andreas Kling 2015-01-19 11:34:01 PST 
Comment on attachment 244902 [details]
Patch

r=me
Comment 3 Sergio Villar Senin 2015-01-20 01:19:51 PST 
Committed r178701: <http://trac.webkit.org/changeset/178701>