Bug 139047 - [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk
Summary: [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 143605
  Show dependency treegraph
 
Reported: 2014-11-25 09:27 PST by Akos Kiss
Modified: 2015-04-10 07:16 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch. (27.62 KB, patch)
2014-11-25 11:26 PST, Akos Kiss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Akos Kiss 2014-11-25 09:27:38 PST
After some changes, the patch that was used to make LLVM work correctly in FTL JIT on x86-64/Linux/{EFL,GTK} got accepted to LLVM trunk. 
http://reviews.llvm.org/rL222760

Seems to be a good idea to replace the original but "unofficial" patch in Tools/{efl,gtk}/patches with the one accepted to LLVM trunk.
Comment 1 Carlos Garcia Campos 2014-11-25 09:37:55 PST
That also means that FTL should work with llvm from git master, right? Maybe we could use a git repo instead of a tarball in jhbuild, using the revision when the patch landed, and we don't need to use any patch. At least until a new version is released.
Comment 2 Akos Kiss 2014-11-25 11:26:18 PST
Created attachment 242205 [details]
Proposed patch.

Discussed with KaL on irc that stability should be considered: we trust the 3.5.0 release of LLVM to be reasonably stable and applying 2 patches is not a big overhead. So, instead of grabbing a revision from master, I'd still go with this approach.

Did clean builds (update-webkit*-libs, update-webkit*-libs llvm, build-jsc --ftl-jit) both for EFL and GTK, all jsc tests pass.
Comment 3 Carlos Garcia Campos 2014-11-25 23:29:47 PST
Comment on attachment 242205 [details]
Proposed patch.

Thanks!
Comment 4 WebKit Commit Bot 2014-11-26 00:08:00 PST
Comment on attachment 242205 [details]
Proposed patch.

Clearing flags on attachment: 242205

Committed r176546: <http://trac.webkit.org/changeset/176546>
Comment 5 WebKit Commit Bot 2014-11-26 00:08:05 PST
All reviewed patches have been landed.  Closing bug.