Bug 139040 – [MSE] Rename highest presentation end timestamp to group end timestamp, per spec

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Media

[Bartlomiej Gajda]

According to http://www.w3.org/TR/media-source/#revision-history
01 April 2014 : "Bug 24820 - Renamed highest presentation end timestamp to group end timestamp and fixed a few related issues."

This does the rename part.

[Bartlomiej Gajda]

Created attachment 242193 [details]
patch v1

[Bartlomiej Gajda]

Also according to spec Group End Timestamp should be intialized to 0, not to invalid time as it is now. 

Before 01.04.2014 revision there was line:

"If highest presentation end timestamp is unset or frame end timestamp is greater than highest presentation ..."

but now it's:

"If frame end timestamp is greater than group end timestamp, then set group end timestmap..."

Shall I add this to this change, or make another bug for it?

[Sam Weinig]

(In reply to comment #2)
> Also according to spec Group End Timestamp should be intialized to 0, not to
> invalid time as it is now. 
> 
> Before 01.04.2014 revision there was line:
> 
> "If highest presentation end timestamp is unset or frame end timestamp is
> greater than highest presentation ..."
> 
> but now it's:
> 
> "If frame end timestamp is greater than group end timestamp, then set group
> end timestmap..."
> 
> Shall I add this to this change, or make another bug for it?

You could do all that in one change, but you would need a test case if you change behavior.

[Bartlomiej Gajda]

*** This bug has been marked as a duplicate of bug 139265 ***