details: https://bugs.webkit.org/show_bug.cgi?id=137742#c23 fix is coming
Created attachment 242181 [details] Patch
Thanks Ossy for the fix, it's great.
Created attachment 242189 [details] Patch [EFL] prefix added to the changelog
Comment on attachment 242189 [details] Patch LGTM.
Comment on attachment 242189 [details] Patch Clearing flags on attachment: 242189 Committed r176538: <http://trac.webkit.org/changeset/176538>
All reviewed patches have been landed. Closing bug.
One question. You made some changes to jhbuildrc. Could you tell me when those configurations are used ?.
Comment on attachment 242189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242189&action=review > Tools/efl/jhbuildrc:40 > +if not 'ACCESSIBILITY_EAIL_LIBRARY_PATH' in os.environ: > + _libeail_path = os.path.join(os.environ['CMAKE_LIBRARY_PATH'], 'libeail.so') > + if os.path.isfile(_libeail_path): > + os.environ['ACCESSIBILITY_EAIL_LIBRARY_PATH'] = _libeail_path > + (In reply to comment #7) > One question. You made some changes to jhbuildrc. Could you tell me when > those configurations are used ?. I think developers don't know anything about ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable, most of them are never set it to anything. In this common case jhbuild set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so if this file exists to make your code happy. If the optional module is built by jhbuild then run-webkit-tests, run-perf-tests, run-launcher, ... pass through this env to WebKitTestRunner/MiniBrowser. (efl.py change is needed to pass through the environment to WTR. Without explicit request, environment variables aren't pass through to WTR.) But if the user explicitly set ACCESSIBILITY_EAIL_LIBRARY_PATH env, jhbuildrc doesn't change it, simply pass through to the WTR/MiniBrowser.