Bug 139035 - Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
Summary: Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-24 15:25 PST by zalan
Modified: 2014-11-24 17:00 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.69 KB, patch)
2014-11-24 15:32 PST, zalan 		koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-11-24 15:25:09 PST 
and move logic to FlowContents.
This is in preparation to support <br>.
Comment 1 zalan 2014-11-24 15:32:17 PST 
Created attachment 242178 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-24 16:22:52 PST 
Comment on attachment 242178 [details]
Patch

Rejecting attachment 242178 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242178, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
9712efb79390b7a1afa94a8d5596cacc06d
r176525 = 7076abaf2ba8b671c65abbdbd28ac975c12ba0c7
r176526 = ef27ea42f08d6334a7a12e2ba94282e6e5869e30
r176527 = 62bd3d223a98992992e47c5c037ecdc6e7665f0d
r176528 = 5ae60b7a58d7bbb0ba241fc0a6e01bc434adaedd
r176529 = c44f54edffa8a4d06bb67881fce44e4c9b7a724a
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5886013125689344
Comment 3 zalan 2014-11-24 17:00:42 PST 
Committed r176531: <http://trac.webkit.org/changeset/176531>