WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139035
Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
https://bugs.webkit.org/show_bug.cgi?id=139035
Summary
Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
zalan
Reported
2014-11-24 15:25:09 PST
and move logic to FlowContents. This is in preparation to support <br>.
Attachments
Patch
(6.69 KB, patch)
2014-11-24 15:32 PST
,
zalan
koivisto
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2014-11-24 15:32:17 PST
Created
attachment 242178
[details]
Patch
WebKit Commit Bot
Comment 2
2014-11-24 16:22:52 PST
Comment on
attachment 242178
[details]
Patch Rejecting
attachment 242178
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242178, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 9712efb79390b7a1afa94a8d5596cacc06d
r176525
= 7076abaf2ba8b671c65abbdbd28ac975c12ba0c7
r176526
= ef27ea42f08d6334a7a12e2ba94282e6e5869e30
r176527
= 62bd3d223a98992992e47c5c037ecdc6e7665f0d
r176528
= 5ae60b7a58d7bbb0ba241fc0a6e01bc434adaedd
r176529
= c44f54edffa8a4d06bb67881fce44e4c9b7a724a Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output:
http://webkit-queues.appspot.com/results/5886013125689344
zalan
Comment 3
2014-11-24 17:00:42 PST
Committed
r176531
: <
http://trac.webkit.org/changeset/176531
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug