Bug 139013 – Fix the parsing and re-serialization of :lang pseudo class selector when it has multiple arguments with same value

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dhi Aurrahman]

Fix the parsing and re-serialization of :lang pseudo class css selector when it has multiple arguments with same value

[Dhi Aurrahman]

Created attachment 242131 [details]
Patch

[Benjamin Poulain]

Comment on attachment 242131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242131&action=review

Great catch + great test.

I'll change the loop to an enumerated loop for landing. I think that will make such cases clearer.

> Source/WebCore/css/CSSSelector.cpp:347
> -    const AtomicString& lastArgument = argumentList.last();
> -    for (const AtomicString argument : argumentList) {
> +    const AtomicString* lastArgument = &argumentList.last();
> +    for (const AtomicString& argument : argumentList) {
>          str.append(argument);
> -        if (argument != lastArgument)
> +        if (&argument != lastArgument)
>              str.appendLiteral(", ");
>      }

Great catch, I did not think of this while reviewing.

[Benjamin Poulain]

Created attachment 242185 [details]
Patch for landing

[Benjamin Poulain]

Comment on attachment 242185 [details]
Patch for landing

Arg, of course I had to mess up the edit :(

[Benjamin Poulain]

Created attachment 242186 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 242186 [details]
Patch

Clearing flags on attachment: 242186

Committed r176535: <http://trac.webkit.org/changeset/176535>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.