Bug 139007 - Simple line layout: canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
Summary: Simple line layout: canUseFor() should iterate through RenderTexts to check i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-22 15:24 PST by zalan
Modified: 2014-11-24 19:47 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2014-11-22 15:43 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.32 KB, patch)
2014-11-23 17:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.19 KB, patch)
2014-11-24 13:33 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-11-22 15:24:04 PST 
as opposed to just check the first child.
Comment 1 zalan 2014-11-22 15:43:56 PST 
Created attachment 242124 [details]
Patch
Comment 2 Antti Koivisto 2014-11-23 01:15:29 PST 
Good catch. Needs some tests.
Comment 3 zalan 2014-11-23 17:12:22 PST 
Created attachment 242137 [details]
Patch
Comment 4 Antti Koivisto 2014-11-24 00:26:37 PST 
Comment on attachment 242137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242137&action=review

> LayoutTests/ChangeLog:9
> +        * fast/text/simple-line-layout-multiple-renderes-non-breaking-space-expected.html: Added.
> +        * fast/text/simple-line-layout-multiple-renderes-non-breaking-space.html: Added.

These two files look identical?
Comment 5 zalan 2014-11-24 13:33:09 PST 
Created attachment 242171 [details]
Patch
Comment 6 WebKit Commit Bot 2014-11-24 16:10:03 PST 
Comment on attachment 242171 [details]
Patch

Clearing flags on attachment: 242171

Committed r176527: <http://trac.webkit.org/changeset/176527>
Comment 7 WebKit Commit Bot 2014-11-24 16:10:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 zalan 2014-11-24 19:47:43 PST 
Committed r176534: <http://trac.webkit.org/changeset/176534>