RESOLVED FIXED 138989
The preview action menu item should not have a title 
https://bugs.webkit.org/show_bug.cgi?id=138989
Summary The preview action menu item should not have a title
Beth Dakin
Reported 2014-11-21 15:45:43 PST
The preview action menu item should not have a title rdar://problem/19061959
Attachments
Patch (1.38 KB, patch)
2014-11-21 15:48 PST, Beth Dakin 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-11-21 15:48:56 PST
Created attachment 242088 [details] Patch
mitz
Comment 2 2014-11-21 15:52:56 PST
Comment on attachment 242088 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242088&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:-843 > - title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item"); Does this leave an unused key in the localizable strings file?
Beth Dakin
Comment 3 2014-11-21 15:54:47 PST
(In reply to comment #2) > Comment on attachment 242088 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242088&action=review > > > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:-843 > > - title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item"); > > Does this leave an unused key in the localizable strings file? Not currently since we do still (intentionally) use the string in WK1.
Beth Dakin
Comment 4 2014-11-21 16:20:16 PST
Thanks! http://trac.webkit.org/changeset/176485
Note You need to log in before you can comment on or make changes to this bug.