Bug 138989 - The preview action menu item should not have a title
Summary: The preview action menu item should not have a title
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-21 15:45 PST by Beth Dakin
Modified: 2014-11-21 16:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2014-11-21 15:48 PST, Beth Dakin 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-11-21 15:45:43 PST 
The preview action menu item should not have a title

rdar://problem/19061959
Comment 1 Beth Dakin 2014-11-21 15:48:56 PST 
Created attachment 242088 [details]
Patch
Comment 2 mitz 2014-11-21 15:52:56 PST 
Comment on attachment 242088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242088&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:-843
> -        title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item");

Does this leave an unused key in the localizable strings file?
Comment 3 Beth Dakin 2014-11-21 15:54:47 PST 
(In reply to comment #2)
> Comment on attachment 242088 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242088&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:-843
> > -        title = WEB_UI_STRING_KEY("Preview", "Preview (action menu item)", "action menu item");
> 
> Does this leave an unused key in the localizable strings file?

Not currently since we do still (intentionally) use the string in WK1.
Comment 4 Beth Dakin 2014-11-21 16:20:16 PST 
Thanks! http://trac.webkit.org/changeset/176485