Remove the Timer parameters from timer callbacks
Created attachment 242059 [details] Patch
Attachment 242059 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContext.cpp:490: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContext.cpp:492: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/Frame.cpp:165: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/Modules/geolocation/Geolocation.h:189: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/Scrollbar.cpp:79: Wrong number of spaces before statement. (expected: 25) [whitespace/indent] [4] Total errors found: 5 in 240 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 242062 [details] Patch
Attachment 242062 [details] did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContext.cpp:490: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContext.cpp:492: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/Frame.cpp:165: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/Modules/geolocation/Geolocation.h:189: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/Scrollbar.cpp:79: Wrong number of spaces before statement. (expected: 25) [whitespace/indent] [4] Total errors found: 5 in 242 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r176459: <http://trac.webkit.org/changeset/176459>
(In reply to comment #5) > Committed r176459: <http://trac.webkit.org/changeset/176459> This broke both the GTK and EFL builds: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/52986
(In reply to comment #6) > (In reply to comment #5) > > Committed r176459: <http://trac.webkit.org/changeset/176459> > > This broke both the GTK and EFL builds: > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20%28Build%29/builds/52986 I fix this build break on EFL port - <http://trac.webkit.org/changeset/176495> I hope this commit will fix GTK port as well.
Comment on attachment 242062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242062&action=review > Source/WebCore/Modules/mediastream/MediaStream.cpp:89 > - , m_scheduledEventTimer(this, &MediaStream::scheduledEventTimerFired) > + , m_scheduledEventtimer(*this, &MediaStream::scheduledEventTimerFired) Why did you change the camal case? > Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp:68 > - , m_scheduledEventTimer(this, &RTCDTMFSender::scheduledEventTimerFired) > + , m_scheduledEventtimer(*this, &RTCDTMFSender::scheduledEventTimerFired) ditto > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:98 > - , m_scheduledEventTimer(this, &RTCDataChannel::scheduledEventTimerFired) > + , m_scheduledEventtimer(*this, &RTCDataChannel::scheduledEventTimerFired) ditto > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:177 > - , m_scheduledEventTimer(this, &RTCPeerConnection::scheduledEventTimerFired) > + , m_scheduledEventtimer(*this, &RTCPeerConnection::scheduledEventTimerFired) ditto
(In reply to comment #3) - 2014-11-21 12:00:39 PST > Created attachment 242062 [details] > Patch (In reply to comment #5) - 2014-11-21 12:10:02 PST > Committed r176459: <http://trac.webkit.org/changeset/176459> Common, was it really necessary to land this huge patch in 9.5 minutes after uploading and breaking GTK/EFL builds with trivial typos and not complete grepping? And then just let it broken. :(( https://trac.webkit.org/changeset/176495 fixed many issues in WebCore. Is there a new rule that you are allowed to break WebCore build too? As far as I know, it is for WebKit2 only, not for WebCore.
GTK fix landed in https://trac.webkit.org/changeset/176503