Bug 13897 – Dragging a file onto <input type="file"> should give distinct visual feedback

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[David Kilzer (:ddkilzer)]

When dragging files onto an <input type="file"> element, visual feedback is required so that the user knows where to drop the file so that it will be set as the file upload path instead of being opened in the browser.

Regarding visual feedback, I think either a cursor change or a focus ring around the input element (or both) would be sufficient.

See:  <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">

[David Kilzer (:ddkilzer)]

<rdar://problem/5232483>

The previous implementation applied a tint to the background of the control when it was being targeted.

[Oliver Hunt]

I see a (+) cursor when i drag a file over the input.

But yes, it would probably help if there was some kind of feedback that was more distinguishable

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> I see a (+) cursor when i drag a file over the input.

That's true for any document type that Safari will accept, like an image or HTML.  The (+) cursor starts when you enter the page boundary, not when you get to the input element, so you don't know what will happen when you drop it.  :(

[David Kilzer (:ddkilzer)]

*** Bug 15753 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

When I initially added type=file drops, it drew a focus ring.  it was a bit strange looking on some sites, but it worked.  That support was lost when forms moved out of NSViews, it seems.

[David Kilzer (:ddkilzer)]

*** Bug 17024 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

*** Bug 32493 has been marked as a duplicate of this bug. ***

[Jon Lee]

<rdar://problem/5232483>

[Jon Lee]

Split out some tasks for the multiple file case. This bug can track the single file drag case.

[Jon Lee]

Created attachment 113733 [details]
Patch

Comment on attachment 113733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113733&action=review

r- because of the potential stale pointer issue. Other than that I think the patch is okay!

> Source/WebCore/page/DragController.h:121
> +        HTMLInputElement* m_fileInputElementUnderMouse;

I am not convinced that using a raw pointer here is safe. For example, it seems like a script could remove the element from the document while the user is dragging.

[Jon Lee]

Created attachment 113757 [details]
Patch

Comment on attachment 113757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113757&action=review

> Source/WebCore/page/DragController.cpp:91
> +    , m_fileInputElementUnderMouse(0)

No need to initialize a RefPtr to 0.

[Jon Lee]

Committed r99369: <http://trac.webkit.org/changeset/99369>