RESOLVED FIXED 138962
[JSC] Disable verifyHeap 
https://bugs.webkit.org/show_bug.cgi?id=138962
Summary [JSC] Disable verifyHeap
Csaba Osztrogonác
Reported 2014-11-21 05:36:35 PST
[JSC] Disable verifyHeap
Attachments
Patch (1.21 KB, patch)
2014-11-21 05:36 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-11-21 05:36:46 PST
Created attachment 242042 [details] Patch Disable verifyHeap, because it was enabled by mistake in r176424.
Csaba Osztrogonác
Comment 2 2014-11-21 05:39:23 PST
In Bug138851 and in the changelog of http://trac.webkit.org/r176424 we can see clear that "The verification infrastructure code is always built in but disabled by default." So it seems it was enabled accidentally and should be disabled. I noticed it, because this change made 30 JSC tests timeout our ARM bots: - http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Linux%20Release%20%28Build%29/builds/6996 - http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Traditional%20Linux%20Release%20%28Build%29/builds/7745
Mark Lam
Comment 3 2014-11-21 06:48:08 PST
Comment on attachment 242042 [details] Patch r=me
WebKit Commit Bot
Comment 4 2014-11-21 07:25:59 PST
Comment on attachment 242042 [details] Patch Clearing flags on attachment: 242042 Committed r176446: <http://trac.webkit.org/changeset/176446>
WebKit Commit Bot
Comment 5 2014-11-21 07:26:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.