Bug 138962 - [JSC] Disable verifyHeap
Summary: [JSC] Disable verifyHeap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 138851
  Show dependency tree / graph
 
Reported: 2014-11-21 05:36 PST by Csaba Osztrogonác
Modified: 2014-11-21 07:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2014-11-21 05:36 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-11-21 05:36:35 PST 
[JSC] Disable verifyHeap
Comment 1 Csaba Osztrogonác 2014-11-21 05:36:46 PST 
Created attachment 242042 [details]
Patch

Disable verifyHeap, because it was enabled by mistake in r176424.
Comment 2 Csaba Osztrogonác 2014-11-21 05:39:23 PST 
In Bug138851 and in the changelog of http://trac.webkit.org/r176424
we can see clear that "The verification infrastructure code is always
built in but disabled by default."

So it seems it was enabled accidentally and should be disabled.

I noticed it, because this change made 30 JSC tests timeout our ARM bots:
- http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Linux%20Release%20%28Build%29/builds/6996
- http://build.webkit.sed.hu/builders/EFL%20ARMv7%20Traditional%20Linux%20Release%20%28Build%29/builds/7745
Comment 3 Mark Lam 2014-11-21 06:48:08 PST 
Comment on attachment 242042 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-11-21 07:25:59 PST 
Comment on attachment 242042 [details]
Patch

Clearing flags on attachment: 242042

Committed r176446: <http://trac.webkit.org/changeset/176446>
Comment 5 WebKit Commit Bot 2014-11-21 07:26:03 PST 
All reviewed patches have been landed.  Closing bug.