[EFL] Use a variable to set flicking time instead of hardcoding

[Sanghyup Lee]

Currently time of flick gesture animation is hardcoded as one second.
This patch added a variable for it to increase readability.

[Sanghyup Lee]

Created attachment 242023 [details]
Patch

[Ryuan Choi]

Comment on attachment 242023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242023&action=review

> Source/WebKit2/ChangeLog:9
> +        Currently time of flick gesture animation is hardcoded as one second.
> +        This patch added a variable for it to increase readability.

Then, why you should add it to normal member variable instead of static variable?

[Sanghyup Lee]

(In reply to comment #2)
> Comment on attachment 242023 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242023&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Currently time of flick gesture animation is hardcoded as one second.
> > +        This patch added a variable for it to increase readability.
> 
> Then, why you should add it to normal member variable instead of static
> variable?

It's my mistake. I'll fix it.

[Sanghyup Lee]

Created attachment 242028 [details]
Patch

[Sanghyup Lee]

Created attachment 242029 [details]
Patch

[Ryuan Choi]

Comment on attachment 242029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242029&action=review

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:236
> +    float multiplier = easeInOutQuad(gestureHandler->m_flickIndex, 0, gestureHandler->s_flickTime, gestureHandler->m_flickDuration);

gestureHandler looks not needed anymore.

[Sanghyup Lee]

Created attachment 246257 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 246257 [details]
Patch for landing

Clearing flags on attachment: 246257

Committed r179867: <http://trac.webkit.org/changeset/179867>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.