Bug 138947 - REGRESSION(r175259) Simple line layout text measuring behavior changed.
Summary: REGRESSION(r175259) Simple line layout text measuring behavior changed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-11-20 20:22 PST by zalan
Modified: 2014-11-21 13:08 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.05 KB, patch)
2014-11-20 20:42 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.11 KB, patch)
2014-11-20 20:44 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.81 KB, patch)
2014-11-20 21:26 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.91 KB, patch)
2014-11-21 11:36 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-11-20 20:22:23 PST 
Complex line layout measures text including the trailing space and it subtracts (the constant value of) space width afterwards. 
'FOO ' -> 55.5px -> subtract 4px for space -> 51.5px
vs.
'FOO' -> 51.5px 
It certain cases, this results in different word width and forces unexpected line breaking.
Comment 1 zalan 2014-11-20 20:42:08 PST 
Created attachment 242019 [details]
Patch
Comment 2 zalan 2014-11-20 20:43:01 PST 
rdar://problem/19050653
Comment 3 zalan 2014-11-20 20:44:39 PST 
Created attachment 242020 [details]
Patch
Comment 4 zalan 2014-11-20 21:26:54 PST 
Created attachment 242021 [details]
Patch
Comment 5 zalan 2014-11-21 11:36:14 PST 
Created attachment 242056 [details]
Patch
Comment 6 WebKit Commit Bot 2014-11-21 13:08:44 PST 
Comment on attachment 242056 [details]
Patch

Clearing flags on attachment: 242056

Committed r176470: <http://trac.webkit.org/changeset/176470>
Comment 7 WebKit Commit Bot 2014-11-21 13:08:48 PST 
All reviewed patches have been landed.  Closing bug.