Bug 138932 - Add parsing for :dir()
Summary: Add parsing for :dir()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-20 13:41 PST by Sukolsak Sakshuwong
Modified: 2014-11-25 16:27 PST (History)
3 users (show)

See Also:


Attachments
Patch (17.46 KB, patch)
2014-11-20 13:52 PST, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff
Patch (17.49 KB, patch)
2014-11-25 01:54 PST, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2014-11-20 13:41:35 PST
See http://dev.w3.org/csswg/selectors4/#the-dir-pseudo
Comment 1 Sukolsak Sakshuwong 2014-11-20 13:52:35 PST
Created attachment 241977 [details]
Patch
Comment 2 Benjamin Poulain 2014-11-25 01:20:40 PST
Comment on attachment 241977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241977&action=review

Everything looks good. The tests are great.

> Source/WebCore/css/CSSGrammar.y.in:67
>      case MATCHESFUNCTION:

Hum, you'll need to update before landing, I moved this one.
Comment 3 Sukolsak Sakshuwong 2014-11-25 01:54:45 PST
Created attachment 242190 [details]
Patch
Comment 4 Benjamin Poulain 2014-11-25 15:50:23 PST
Comment on attachment 242190 [details]
Patch

Let's land!
Comment 5 WebKit Commit Bot 2014-11-25 16:27:36 PST
Comment on attachment 242190 [details]
Patch

Clearing flags on attachment: 242190

Committed r176545: <http://trac.webkit.org/changeset/176545>
Comment 6 WebKit Commit Bot 2014-11-25 16:27:39 PST
All reviewed patches have been landed.  Closing bug.