138923 – Rename String.prototype.contains to String.prototype.includes

Bug 138923 - Rename String.prototype.contains to String.prototype.includes

Summary: Rename String.prototype.contains to String.prototype.includes

Attachments
Patch (41.77 KB, patch) 2014-11-20 02:29 PST, Yusuke Suzuki	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yusuke Suzuki 2014-11-20 02:22:27 PST

Rename String.prototype.contains to String.prototype.includes

Comment 1 Yusuke Suzuki 2014-11-20 02:29:03 PST

Created attachment 241937 [details]
Patch

Comment 2 Yusuke Suzuki 2014-11-20 02:38:41 PST

Change in V8:
https://codereview.chromium.org/742963002

Comment 3 Geoffrey Garen 2014-11-20 10:12:59 PST

Comment on attachment 241937 [details]
Patch

r=me

Comment 4 Yusuke Suzuki 2014-11-20 10:20:45 PST

(In reply to comment #3)
> Comment on attachment 241937 [details]
> Patch
> 
> r=me

Thank you for your review :)

Comment 5 WebKit Commit Bot 2014-11-20 10:50:50 PST

Comment on attachment 241937 [details]
Patch

Clearing flags on attachment: 241937

Committed r176404: <http://trac.webkit.org/changeset/176404>

Comment 6 WebKit Commit Bot 2014-11-20 10:50:55 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Yusuke Suzuki 2014-11-20 11:01:26 PST

Add additional pointers:
https://bugzilla.mozilla.org/show_bug.cgi?id=1102219

Comment 8 Benjamin Poulain 2014-11-20 11:22:05 PST

Aww, I liked String.contains better :(