Bug 138910 - New perf dashboard should provide UI to create a new analysis task
Summary: New perf dashboard should provide UI to create a new analysis task
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 138516
  Show dependency tree / graph
 
Reported: 2014-11-19 20:36 PST by Ryosuke Niwa
Modified: 2016-02-16 13:52 PST (History)
5 users (show)

See Also:

Attachments
Patch (32.33 KB, patch)
2014-11-19 21:13 PST, Ryosuke Niwa 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-11-19 20:36:07 PST 
Now that we've added the UI to see an analysis task in the bug 138517,
we should also add the UI to create one.
Comment 1 Ryosuke Niwa 2014-11-19 21:13:25 PST 
Created attachment 241926 [details]
Patch
Comment 2 Benjamin Poulain 2014-11-20 14:49:13 PST 
Comment on attachment 241926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241926&action=review

rs=me

> Websites/perf.webkit.org/public/v2/app.js:1312
> +        if (!offset || !$(event.target).closest('svg').length)

closest! :)

> Websites/perf.webkit.org/public/v2/app.js:1452
> +                return (+firstPoint.time + +secondPoint.time) / 2;

Are all the "+" intended?
Comment 3 Ryosuke Niwa 2014-11-20 14:53:04 PST 
Comment on attachment 241926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241926&action=review

>> Websites/perf.webkit.org/public/v2/app.js:1452
>> +                return (+firstPoint.time + +secondPoint.time) / 2;
> 
> Are all the "+" intended?

Yes, I need to convert them to integer first.
Comment 4 Ryosuke Niwa 2014-11-20 15:24:54 PST 
Committed r176422: <http://trac.webkit.org/changeset/176422>