AX: Unclear that user and password are autofilled, no VoiceOver version of the yellow outline.

[chris fleizach]

If I find my focus in a user field with password already filled in, I am unaware of the difference between the website filling the content via cookie or other means, vs Safari's form filling function. Visually this is indicated with the yellow outline, and is not conveyed to the VO user.


<rdar://problem/18900545>

[chris fleizach]

Created attachment 241918 [details]
patch

[Csaba Osztrogonác]

Comment on attachment 241918 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241918&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:1984
> +    return downcast<HTMLInputElement>(*node).isAutofilled();

../../Source/WebCore/accessibility/AccessibilityObject.cpp: In member function 'bool WebCore::AccessibilityObject::isValueAutofilled() const':
../../Source/WebCore/accessibility/AccessibilityObject.cpp:1984:45: error: invalid use of incomplete type 'class WebCore::HTMLInputElement'
     return downcast<HTMLInputElement>(*node).isAutofilled();
                                             ^

[chris fleizach]

(In reply to comment #2)
> Comment on attachment 241918 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241918&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:1984
> > +    return downcast<HTMLInputElement>(*node).isAutofilled();
> 
> ../../Source/WebCore/accessibility/AccessibilityObject.cpp: In member
> function 'bool WebCore::AccessibilityObject::isValueAutofilled() const':
> ../../Source/WebCore/accessibility/AccessibilityObject.cpp:1984:45: error:
> invalid use of incomplete type 'class WebCore::HTMLInputElement'
>      return downcast<HTMLInputElement>(*node).isAutofilled();
>                                              ^

Must be missing an #include for HTMLInputElement.

[chris fleizach]

Created attachment 241956 [details]
patch

[chris fleizach]

I think the EFL failure is unrelated

-----------
-MT Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderBlock.cpp.o -MF "Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderBlock.cpp.o.d" -o Source/WebCore/CMakeFiles/WebCore.dir/rendering/RenderBlock.cpp.o -c ../../Source/WebCore/rendering/RenderBlock.cpp
c++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions.
ninja: build stopped: subcommand failed.

[Mario Sanchez Prada]

Comment on attachment 241956 [details]
patch

I agree on that the EFL error seems unrelated

[WebKit Commit Bot]

Comment on attachment 241956 [details]
patch

Clearing flags on attachment: 241956

Committed r176481: <http://trac.webkit.org/changeset/176481>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.