RESOLVED FIXED 138872
[CMake] Build failure against GStreamer git master 
https://bugs.webkit.org/show_bug.cgi?id=138872
Summary [CMake] Build failure against GStreamer git master
Philippe Normand
Reported 2014-11-19 07:58:36 PST
In current GStreamer git master gstversion.h was moved to a different directory but our CMake build looks for it in the first include directory reported by pkg-config. I think there's a great deal of cruft in FindGStreamer.cmake. It does weird version checks and it's unable to handle a library with multiple include directories...
Attachments
patch (5.46 KB, patch)
2014-11-24 00:47 PST, Philippe Normand 		ossy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2014-11-20 07:55:27 PST
Must have been a mix of gst versions in my jhbuild sysroot...
Philippe Normand
Comment 2 2014-11-21 09:15:34 PST
Now it appears again, perhaps ccache tricked me last time...
Philippe Normand
Comment 3 2014-11-24 00:47:54 PST
Created attachment 242147 [details] patch
Philippe Normand
Comment 4 2014-11-28 06:33:40 PST
Ossy, would you like to review this patch?
Csaba Osztrogonác
Comment 5 2014-11-28 06:53:46 PST
Comment on attachment 242147 [details] patch looks good, r=me.
Philippe Normand
Comment 6 2014-11-28 07:27:39 PST
Committed r176565: <http://trac.webkit.org/changeset/176565>
Note You need to log in before you can comment on or make changes to this bug.