Bug 138872 - [CMake] Build failure against GStreamer git master
Summary: [CMake] Build failure against GStreamer git master
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-11-19 07:58 PST by Philippe Normand
Modified: 2014-11-28 07:27 PST (History)
3 users (show)

See Also:

patch (5.46 KB, patch)
2014-11-24 00:47 PST, Philippe Normand
ossy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2014-11-19 07:58:36 PST
In current GStreamer git master gstversion.h was moved to a different directory but our CMake build looks for it in the first include directory reported by pkg-config.

I think there's a great deal of cruft in FindGStreamer.cmake. It does weird version checks and it's unable to handle a library with multiple include directories...
Comment 1 Philippe Normand 2014-11-20 07:55:27 PST
Must have been a mix of gst versions in my jhbuild sysroot...
Comment 2 Philippe Normand 2014-11-21 09:15:34 PST
Now it appears again, perhaps ccache tricked me last time...
Comment 3 Philippe Normand 2014-11-24 00:47:54 PST
Created attachment 242147 [details]
Comment 4 Philippe Normand 2014-11-28 06:33:40 PST
Ossy, would you like to review this patch?
Comment 5 Csaba Osztrogonác 2014-11-28 06:53:46 PST
Comment on attachment 242147 [details]

looks good, r=me.
Comment 6 Philippe Normand 2014-11-28 07:27:39 PST
Committed r176565: <http://trac.webkit.org/changeset/176565>