Bug 138838 - DOMTimers sometimes don't get unthrottled on scrolling
Summary: DOMTimers sometimes don't get unthrottled on scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 138292
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-18 11:29 PST by Chris Dumez
Modified: 2014-11-18 14:05 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.28 KB, patch)
2014-11-18 12:12 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-18 11:29:14 PST
DOMTimers sometimes don't get unthrottled on scrolling. This is because we stop listening for viewport changes every time the timer fires, but we don't listen for those changes again if we decide the timer should stay throttled after the timer's action was executed.
We should listen for viewport changes again after executing the action, if there are elements outside the viewport causing the DOMTimer to be throttled, even if the throttleState hasn't changed.
Comment 1 Chris Dumez 2014-11-18 12:12:21 PST
Created attachment 241801 [details]
Patch
Comment 2 Chris Dumez 2014-11-18 13:27:40 PST
Comment on attachment 241801 [details]
Patch

Thanks for reviewing quickly.
Comment 3 WebKit Commit Bot 2014-11-18 14:05:02 PST
Comment on attachment 241801 [details]
Patch

Clearing flags on attachment: 241801

Committed r176282: <http://trac.webkit.org/changeset/176282>
Comment 4 WebKit Commit Bot 2014-11-18 14:05:08 PST
All reviewed patches have been landed.  Closing bug.