Bug 138828 – [GTK] Add API to override the default local storage directory

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

It's currently not possible to override the default local storage directory, so that all webkitgtk applications are storing the local storage data in the same directory. This is particularly problematic for private instances like incognito mode. See https://bugzilla.gnome.org/show_bug.cgi?id=738720.
This depends on bug #138826, since the local storage directory path is a construct only configuration, it's not possible to override that for the default web context.

[Carlos Garcia Campos]

Created attachment 241778 [details]
Patch

[Carlos Garcia Campos]

Created attachment 241787 [details]
It should apply now

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Gustavo Noronha (kov)]

Comment on attachment 241787 [details]
It should apply now

View in context: https://bugs.webkit.org/attachment.cgi?id=241787&action=review

So no convenience _new? I think that is ok, but worth noting so you can consider =)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:255
> +    WebKitWebContext* webContext = WEBKIT_WEB_CONTEXT(object);
> +    WebKitWebContextPrivate* priv = webContext->priv;

It doesn't hurt my eyes, but this should move to before the priv->localStorageDictory.isNull check in theory.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:42
> +    // Local Sorage Directory.

This doesn't add much information, I'd do away with it - the variable name is enough documentation.

[Carlos Garcia Campos]

Committed r176512: <http://trac.webkit.org/changeset/176512>