Bug 138825 – [GTK] Mesa build fails over llvm-3.5

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ChangSeok Oh]

I saw a build break for Mesa while running update-weebkitgtk-libs on Ubuntu 14.10.

  CXX      gallivm/lp_bld_debug.lo
gallivm/lp_bld_debug.cpp:61:32: fatal error: llvm/ADT/OwningPtr.h: No such file or directory
 #include <llvm/ADT/OwningPtr.h>
                                ^
compilation terminated.
Makefile:1741: recipe for target 'gallivm/lp_bld_debug.lo' failed
make[3]: *** [gallivm/lp_bld_debug.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
gallivm/lp_bld_tgsi_soa.c: In function 'build_gather':
gallivm/lp_bld_tgsi_soa.c:987:26: warning: 'temp_ptr' may be used uninitialized in this function [-Wmaybe-uninitialized]
             LLVMValueRef val = LLVMBuildLoad(builder, temp_ptr, "");
                          ^
gallivm/lp_bld_tgsi_soa.c:955:17: note: 'temp_ptr' was declared here
    LLVMValueRef temp_ptr;
                 ^
make[3]: Leaving directory '/home/changseok/Projects/WebKit/WebKitBuild/DependenciesGTK/Source/Mesa/src/gallium/auxiliary'
Makefile:1775: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/home/changseok/Projects/WebKit/WebKitBuild/DependenciesGTK/Source/Mesa/src/gallium/auxiliary'
Makefile:529: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/changseok/Projects/WebKit/WebKitBuild/DependenciesGTK/Source/Mesa/src'
Makefile:578: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
*** Error during phase build of mesa: ########## Error running make -j 8 *** [28/29]
*** module webkitgtk-testing-dependencies not built due to non buildable mesa *** [29/29]
*** the following modules were not built *** [29/29]
mesa webkitgtk-testing-dependencies
Running jhbuild-wrapper build failed.
Died at ./Tools/Scripts/update-webkitgtk-libs line 24.

After investiongation on this, I found a relevant fix from mesa upstream. http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp?id=564821c917f4a9d5a0de2ee77b90b0cd85e3d3a6
I believe we need it.

[ChangSeok Oh]

Created attachment 241770 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 241770 [details]
Patch

Clearing flags on attachment: 241770

Committed r176255: <http://trac.webkit.org/changeset/176255>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.