Bug 138771 – AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

Currently the blockquote element is exposed via ATK_ROLE_PANEL, which is completely wrong (PANEL is appropriate for a generic container that holds widgets; not a block of text.)

ATK_ROLE_BLOCK_QUOTE was added to ATK about one year ago. And for environments with older versions of ATK, the fallback mapping should be the same as that of a div element.

[Radar WebKit Bug Importer]

<rdar://problem/18995323>

[Joanmarie Diggs]

Created attachment 241671 [details]
Patch

[Joanmarie Diggs]

Comment on attachment 241671 [details]
Patch

I'm rather surprised that the EFL EWS claims that this patch doesn't build. There's an ATK version check for the added role. And looking at the associated output from from the failure, I'm not seeing anything that suggests the build failure is due to this patch. But having said that, in the spirit of due diligence, I set up a build environment for WebKitEfl. WebKitEfl builds and runs without my patch. WebKitEfl also builds and runs with my patch applied. <insert shrug here>

So I'm going to assume the EWS failure was some fluke or other issue not related to this patch. If the failure really was caused by my patch, feel free to roll it out and tell me how I broke your port so that I can fix it.

[WebKit Commit Bot]

Comment on attachment 241671 [details]
Patch

Rejecting attachment 241671 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 241671, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 FAILED -- saving rejects to file Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/efl/accessibility/roles-exposed-expected.txt
patching file LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5847257488293888

[Joanmarie Diggs]

Created attachment 241679 [details]
Patch

[Joanmarie Diggs]

Bah. Was uploading a master-compatible version of the same, reviewed patch. (Because it no longer applies cleanly after subsequent commits I made.) I forgot to use --no-review with webkit-patch. On the bright side, we can see if the EFL EWS still spits up. ;)

Chris, since it's probably not kosher for me to r+ my own patch, assuming the EFL bot doesn't spit up again, mind re-r+ing it?

[Joanmarie Diggs]

Comment on attachment 241679 [details]
Patch

Was chatting with Martin Robinson:

<mr obinson> Oh, definitely if it's just a rebase to merge with the current code.
<mr obinson> I'd just commit in that case.

Doing that now.

[WebKit Commit Bot]

Comment on attachment 241679 [details]
Patch

Clearing flags on attachment: 241679

Committed r176162: <http://trac.webkit.org/changeset/176162>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.